Issue 13752043: hostnamed site collections support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13752043: hostnamed site collections support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Tanmay Vartak

Modified:
10 years, 7 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -8 lines)			Patch
	M	src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java	View		8 chunks	+66 lines, -6 lines	1 comment	Download
	M	test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java	View		9 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ejona

LGTM https://codereview.appspot.com/13752043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/13752043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode358 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:358: // Loop through all site collections and add ...

10 years, 7 months ago (2013-09-19 00:35:47 UTC) #3

Tanmay Vartak

10 years, 7 months ago (2013-09-19 21:23:07 UTC) #4

On 2013/09/19 00:35:47, ejona wrote:
> LGTM
> 
>
https://codereview.appspot.com/13752043/diff/1/src/com/google/enterprise/adap...
> File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
> (right):
> 
>
https://codereview.appspot.com/13752043/diff/1/src/com/google/enterprise/adap...
> src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:358: //
Loop
> through all site collections and add them to
> Include "host-named" site collections? Since this code isn't necessary for
> normal site collections.

Code Commit :
https://code.google.com/p/plexi/source/detail?r=8ef61242a1f5495baf50b35397c04...

Expand All Messages | Collapse All Messages