Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Issue 13722046: code review 13722046: cmd/nm: make -S listing a bit more accurate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
iant
CC:
golang-dev, iant
Visibility:
Public.

Description

cmd/nm: make -S listing a bit more accurate Hide container symbols like text and etext so that the individual pieces inside are shown instead. For example, if text and main.init have the same address, it was a toss-up which name was printed.

Patch Set 1 #

Patch Set 2 : diff -r e47e60d39fc2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e47e60d39fc2 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e47e60d39fc2 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r abec1f16cd7f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/cmd/nm/nm.c View 1 2 3 4 2 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2013-09-16 22:38:03 UTC) #1
iant
LGTM https://codereview.appspot.com/13722046/diff/9001/src/cmd/nm/nm.c File src/cmd/nm/nm.c (right): https://codereview.appspot.com/13722046/diff/9001/src/cmd/nm/nm.c#newcode308 src/cmd/nm/nm.c:308: "egcdata", What about enoptrdata and enoptrbss?
10 years, 6 months ago (2013-09-17 00:22:13 UTC) #2
rsc
added, thanks. and i have now checked it against ld, so i don't think there ...
10 years, 6 months ago (2013-09-17 00:27:40 UTC) #3
rsc
10 years, 6 months ago (2013-09-17 00:28:02 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=39f0a725531e ***

cmd/nm: make -S listing a bit more accurate

Hide container symbols like text and etext so that
the individual pieces inside are shown instead.
For example, if text and main.init have the same
address, it was a toss-up which name was printed.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13722046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b