Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5345)

Issue 13720049: scripts: improve strip-whitespace.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by janek
Modified:
10 years, 6 months ago
Reviewers:
dak, Julien Rioux
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

scripts: improve strip-whitespace.py previous version barfed when it was called on a directory (which could happen for example when called with a wildcard). Also, add comment.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M scripts/auxiliar/strip-whitespace.py View 1 chunk +22 lines, -12 lines 1 comment Download

Messages

Total messages: 5
Julien Rioux
LGTM. You might want to add to your comment at the top: "Also convert the ...
10 years, 7 months ago (2013-09-27 12:04:04 UTC) #1
dak
https://codereview.appspot.com/13720049/diff/1/scripts/auxiliar/strip-whitespace.py File scripts/auxiliar/strip-whitespace.py (right): https://codereview.appspot.com/13720049/diff/1/scripts/auxiliar/strip-whitespace.py#newcode15 scripts/auxiliar/strip-whitespace.py:15: print 'Stripping trailing whitespace from', pathname Please don't gratuitously ...
10 years, 6 months ago (2013-10-02 11:38:19 UTC) #2
janek
2013/9/27 <julien.rioux@gmail.com>: > LGTM. You might want to add to your comment at the top: ...
10 years, 6 months ago (2013-10-15 21:16:51 UTC) #3
janek
2013/10/2 <dak@gnu.org>: > > https://codereview.appspot.com/13720049/diff/1/scripts/auxiliar/strip-whitespace.py > File scripts/auxiliar/strip-whitespace.py (right): > > https://codereview.appspot.com/13720049/diff/1/scripts/auxiliar/strip-whitespace.py#newcode15 > scripts/auxiliar/strip-whitespace.py:15: print ...
10 years, 6 months ago (2013-10-15 21:18:22 UTC) #4
janek
10 years, 6 months ago (2013-10-15 21:18:43 UTC) #5
Message was sent while issue was closed.
pushed as ca6e130e62a717b99db393f7262c9b34cb3d127d, closed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b