Issue 13703044: code review 13703044: cmd/gc: fix imported and not used error for import .

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13703044: code review 13703044: cmd/gc: fix imported and not used error for import . (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rsc

Modified:
10 years, 7 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: fix imported and not used error for import . Fixes issues 6420.

Patch Set 1 #

Patch Set 2 : diff -r ebd02fba267b https://code.google.com/p/go/ #

Patch Set 3 : diff -r eed26a876362 https://code.google.com/p/go/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/cmd/gc/lex.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	test/import1.go	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 7 months ago (2013-09-20 19:25:41 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=d7f09de722b6 *** cmd/gc: fix imported and not used error for import . ...

10 years, 7 months ago (2013-09-20 19:25:48 UTC) #2

ken3

10 years, 7 months ago (2013-09-20 22:42:18 UTC) #3

Message was sent while issue was closed.

On 2013/09/20 19:25:48, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=d7f09de722b6 ***
> 
> cmd/gc: fix imported and not used error for import .
> 
> Fixes issues 6420.
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/13703044

lgtm

Expand All Messages | Collapse All Messages