Create InternalHeap.

Create InternalHeap.

This is a heap wrapper that takes any HeapInterface and a MemoryNotificationInterface, and makes the heap notify all allocations as being for internal use.

BUG=
R=sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2278

[chrisha, 2014-08-27 19:59:49]

PTAL?

[Sébastien Marchand, 2014-08-27 21:07:29]

lgtm.

https://codereview.appspot.com/136890043/diff/1/syzygy/agent/asan/heaps/inter...
File syzygy/agent/asan/heaps/internal_heap.cc (right):

https://codereview.appspot.com/136890043/diff/1/syzygy/agent/asan/heaps/inter...
syzygy/agent/asan/heaps/internal_heap.cc:25: :
memory_notifier_(memory_notifier), heap_(heap), notifying_heap_(false) {
you're initializing notifying_heap_ below, remove it from here?

https://codereview.appspot.com/136890043/diff/1/syzygy/agent/asan/heaps/inter...
syzygy/agent/asan/heaps/internal_heap.cc:42: uint32* header =
reinterpret_cast<uint32*>(alloc);
What about casting this as a struct ?

struct InternalHeapEntry {
  uint32 size;
  void* body;
};

not sure if this is really needed, but it might improve the readability.

[chrisha, 2014-08-28 18:43:38]

Thanks, committing.

https://codereview.appspot.com/136890043/diff/1/syzygy/agent/asan/heaps/inter...
File syzygy/agent/asan/heaps/internal_heap.cc (right):

https://codereview.appspot.com/136890043/diff/1/syzygy/agent/asan/heaps/inter...
syzygy/agent/asan/heaps/internal_heap.cc:25: :
memory_notifier_(memory_notifier), heap_(heap), notifying_heap_(false) {
On 2014/08/27 21:07:29, sebmarchand - Google Account wrote:
> you're initializing notifying_heap_ below, remove it from here?

Done.

https://codereview.appspot.com/136890043/diff/1/syzygy/agent/asan/heaps/inter...
syzygy/agent/asan/heaps/internal_heap.cc:42: uint32* header =
reinterpret_cast<uint32*>(alloc);
On 2014/08/27 21:07:29, sebmarchand - Google Account wrote:
> What about casting this as a struct ?
> 
> struct InternalHeapEntry {
>   uint32 size;
>   void* body;
> };
> 
> not sure if this is really needed, but it might improve the readability.

Done.

[chrisha, 2014-08-28 18:44:21]

Committed patchset #3 (id:40001) manually as 2278 (presubmit successful).