Android samples switched to Gradle and Android Studio

Android samples switched to Gradle and Android Studio

Most of these are removals due to the dropping of the old style Eclipse project.  The only interesting changes to review are the following:

M .hgignore
M calendar-android-sample/instructions.html
M tasks-android-sample/instructions.html
A build.gradle
A calendar-android-sample/build.gradle
A settings.gradle
A tasks-android-sample/build.gradle

[peleyal, 2013-09-11 21:51:27]

5 minutes???
not for me :)

stuck with some errors.
Yaniv, can you check those instruction on your MAC and then let me know what
should I change?

Thanks,
Eyal

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
File calendar-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
calendar-android-sample/instructions.html:103:
<i>[someDirectory]</i>/google-api-java-client-samples/build.gradle
why we have this build.gradle and also in calendar-android-sample???
I opened this one calendar-android-sample/build.radle by mistake

Michel had the same thing :(
It's not user friendly

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
calendar-android-sample/instructions.html:104: </code> and click OK.
after that I had an error:
Could not fetch model of type 'IdeaProject' using Gradle installation
'/usr/local/google/home/peleyal/gradle-1.6'.
A problem occurred configuring project ':calendar-android-sample'.
A problem occurred configuring project ':calendar-android-sample'.
Failed to notify project evaluation listener.
Could not resolve all dependencies for configuration
':calendar-android-sample:_DebugCompile'.
Could not find com.google.android.gms:play-services:3.1.36.
Required by:
    samples:calendar-android-sample:unspecified

Consult IDE log for more details (Help | Show Log)

Michael had the same issue as well :)
I also checked again that I install those ones:
Under "Tools", check on "Android SDK Build-tools" revision 18.0.1.
Under "Android 2.2 (API 8)", check on "SDK Platform" and "Google APIs".
Under "Extras", check on "Android Support Repository", "Android Support
Library", "Google Play services", and "Google Repository".

[yanivi, 2013-09-12 01:49:59]

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
File calendar-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
calendar-android-sample/instructions.html:103:
<i>[someDirectory]</i>/google-api-java-client-samples/build.gradle
On 2013/09/11 21:51:27, peleyal wrote:
> why we have this build.gradle and also in calendar-android-sample???
> I opened this one calendar-android-sample/build.radle by mistake
> 
> Michel had the same thing :(
> It's not user friendly 
> 

I updated the instructions to warn that it won't work if you import
calendar-android-sample/build.gradle

Let me know if you have any thoughts of how this could be improved.

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
calendar-android-sample/instructions.html:104: </code> and click OK.
On 2013/09/11 21:51:27, peleyal wrote:
> after that I had an error:
> Could not fetch model of type 'IdeaProject' using Gradle installation
> '/usr/local/google/home/peleyal/gradle-1.6'.
> A problem occurred configuring project ':calendar-android-sample'.
> A problem occurred configuring project ':calendar-android-sample'.
> Failed to notify project evaluation listener.
> Could not resolve all dependencies for configuration
> ':calendar-android-sample:_DebugCompile'.
> Could not find com.google.android.gms:play-services:3.1.36.
> Required by:
>     samples:calendar-android-sample:unspecified
> 
> Consult IDE log for more details (Help | Show Log)
> 
> Michael had the same issue as well :)
> I also checked again that I install those ones:
> Under "Tools", check on "Android SDK Build-tools" revision 18.0.1.
> Under "Android 2.2 (API 8)", check on "SDK Platform" and "Google APIs".
> Under "Extras", check on "Android Support Repository", "Android Support
> Library", "Google Play services", and "Google Repository".

Not sure what's going wrong.  I'll take a look tomorrow.

[yanivi, 2013-09-12 16:38:20]

Instructions improved some more.  Hopefully this is ready to go now...

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
File calendar-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/7002/calendar-android-sample/ins...
calendar-android-sample/instructions.html:104: </code> and click OK.
On 2013/09/12 01:49:59, yanivi wrote:
> On 2013/09/11 21:51:27, peleyal wrote:
> > after that I had an error:
> > Could not fetch model of type 'IdeaProject' using Gradle installation
> > '/usr/local/google/home/peleyal/gradle-1.6'.
> > A problem occurred configuring project ':calendar-android-sample'.
> > A problem occurred configuring project ':calendar-android-sample'.
> > Failed to notify project evaluation listener.
> > Could not resolve all dependencies for configuration
> > ':calendar-android-sample:_DebugCompile'.
> > Could not find com.google.android.gms:play-services:3.1.36.
> > Required by:
> >     samples:calendar-android-sample:unspecified
> > 
> > Consult IDE log for more details (Help | Show Log)
> > 
> > Michael had the same issue as well :)
> > I also checked again that I install those ones:
> > Under "Tools", check on "Android SDK Build-tools" revision 18.0.1.
> > Under "Android 2.2 (API 8)", check on "SDK Platform" and "Google APIs".
> > Under "Extras", check on "Android Support Repository", "Android Support
> > Library", "Google Play services", and "Google Repository".
> 
> Not sure what's going wrong.  I'll take a look tomorrow.

We figured it out: we were using the wrong Android home.  Instructions are now
fixed.

[mnrubin, 2013-09-12 18:46:01]

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/bu...
File calendar-android-sample/build.gradle (right):

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/bu...
calendar-android-sample/build.gradle:1: apply plugin: 'android'
[For my own knowledge] Why do we have this build.gradle file and also the higher
level one, if we aren't referencing this one directly?

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
File calendar-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:33: Studio</a> (which bundles the
Android SDK) or <a
> or

It seems here that you are giving them two equivalent options, yet if they opt
for the latter, the user won't be able to complete a majority of this
instructions.html file ("Setup Project in Android Studio").  Maybe say something
like "...or just Android SDK if you don't want Android Studio."

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:94: <h3>Setup Project in Android
Studio</h3>
> Setup
Set Up   (as one word it's a noun, as two it's a verb)

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:115: <li>Import
<code>calendar-android-sample</code> project
May be unecessary but I don't think it hurts to add something like: To do
so/First, run android-studio/bin/studio.sh

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:145: package and then clicking
"Optimize Imports". Another possibility is that the
> and then clicking "Optimize Imports"

"...in order to delete the imports containing the 'R'".   (This lets them know
what you're trying to achieve with Organize Imports in case it doesn't work.)

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:167: fingerprint.
perhaps mention that maybe the Calendar API isn't enabled in the project

https://codereview.appspot.com/13654043/diff/30001/tasks-android-sample/instr...
File tasks-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/30001/tasks-android-sample/instr...
tasks-android-sample/instructions.html:1: <html>
same comments to this doc as to calendar-android-sample's instructions.html file

[yanivi, 2013-09-12 20:05:36]

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/bu...
File calendar-android-sample/build.gradle (right):

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/bu...
calendar-android-sample/build.gradle:1: apply plugin: 'android'
On 2013/09/12 18:46:02, mnrubin wrote:
> [For my own knowledge] Why do we have this build.gradle file and also the
higher
> level one, if we aren't referencing this one directly?

The high level one just gives minimal high level stuff and then Studio reads
this one for this particular project.  I'm just following the best practices
used by the Google Play services demo zip.

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
File calendar-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:33: Studio</a> (which bundles the
Android SDK) or <a
On 2013/09/12 18:46:02, mnrubin wrote:
> > or
> 
> It seems here that you are giving them two equivalent options, yet if they opt
> for the latter, the user won't be able to complete a majority of this
> instructions.html file ("Setup Project in Android Studio").  Maybe say
something
> like "...or just Android SDK if you don't want Android Studio."

Done.

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:94: <h3>Setup Project in Android
Studio</h3>
On 2013/09/12 18:46:02, mnrubin wrote:
> > Setup
> Set Up   (as one word it's a noun, as two it's a verb)

Done.

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:115: <li>Import
<code>calendar-android-sample</code> project
On 2013/09/12 18:46:02, mnrubin wrote:
> May be unecessary but I don't think it hurts to add something like: To do
> so/First, run android-studio/bin/studio.sh

Done.

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:145: package and then clicking
"Optimize Imports". Another possibility is that the
On 2013/09/12 18:46:02, mnrubin wrote:
> > and then clicking "Optimize Imports"
> 
> "...in order to delete the imports containing the 'R'".   (This lets them know
> what you're trying to achieve with Organize Imports in case it doesn't work.)

Done.

https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
calendar-android-sample/instructions.html:167: fingerprint.
On 2013/09/12 18:46:02, mnrubin wrote:
> perhaps mention that maybe the Calendar API isn't enabled in the project

Done.

https://codereview.appspot.com/13654043/diff/30001/tasks-android-sample/instr...
File tasks-android-sample/instructions.html (right):

https://codereview.appspot.com/13654043/diff/30001/tasks-android-sample/instr...
tasks-android-sample/instructions.html:1: <html>
On 2013/09/12 18:46:02, mnrubin wrote:
> same comments to this doc as to calendar-android-sample's instructions.html
file

Done.

[mnrubin, 2013-09-12 20:10:16]

On 2013/09/12 20:05:36, yanivi wrote:
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/bu...
> File calendar-android-sample/build.gradle (right):
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/bu...
> calendar-android-sample/build.gradle:1: apply plugin: 'android'
> On 2013/09/12 18:46:02, mnrubin wrote:
> > [For my own knowledge] Why do we have this build.gradle file and also the
> higher
> > level one, if we aren't referencing this one directly?
> 
> The high level one just gives minimal high level stuff and then Studio reads
> this one for this particular project.  I'm just following the best practices
> used by the Google Play services demo zip.
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
> File calendar-android-sample/instructions.html (right):
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
> calendar-android-sample/instructions.html:33: Studio</a> (which bundles the
> Android SDK) or <a
> On 2013/09/12 18:46:02, mnrubin wrote:
> > > or
> > 
> > It seems here that you are giving them two equivalent options, yet if they
opt
> > for the latter, the user won't be able to complete a majority of this
> > instructions.html file ("Setup Project in Android Studio").  Maybe say
> something
> > like "...or just Android SDK if you don't want Android Studio."
> 
> Done.
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
> calendar-android-sample/instructions.html:94: <h3>Setup Project in Android
> Studio</h3>
> On 2013/09/12 18:46:02, mnrubin wrote:
> > > Setup
> > Set Up   (as one word it's a noun, as two it's a verb)
> 
> Done.
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
> calendar-android-sample/instructions.html:115: <li>Import
> <code>calendar-android-sample</code> project
> On 2013/09/12 18:46:02, mnrubin wrote:
> > May be unecessary but I don't think it hurts to add something like: To do
> > so/First, run android-studio/bin/studio.sh
> 
> Done.
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
> calendar-android-sample/instructions.html:145: package and then clicking
> "Optimize Imports". Another possibility is that the
> On 2013/09/12 18:46:02, mnrubin wrote:
> > > and then clicking "Optimize Imports"
> > 
> > "...in order to delete the imports containing the 'R'".   (This lets them
know
> > what you're trying to achieve with Organize Imports in case it doesn't
work.)
> 
> Done.
> 
>
https://codereview.appspot.com/13654043/diff/30001/calendar-android-sample/in...
> calendar-android-sample/instructions.html:167: fingerprint.
> On 2013/09/12 18:46:02, mnrubin wrote:
> > perhaps mention that maybe the Calendar API isn't enabled in the project
> 
> Done.
> 
>
https://codereview.appspot.com/13654043/diff/30001/tasks-android-sample/instr...
> File tasks-android-sample/instructions.html (right):
> 
>
https://codereview.appspot.com/13654043/diff/30001/tasks-android-sample/instr...
> tasks-android-sample/instructions.html:1: <html>
> On 2013/09/12 18:46:02, mnrubin wrote:
> > same comments to this doc as to calendar-android-sample's instructions.html
> file
> 
> Done.

LGTM