code review 13647043: go.text/language: A few small changes:

go.text/language: A few small changes:
- Added Tag methods to Base, Script and Region types to convert them in a proper tag.
- Factored out part of Canonicalize that does not remake the string (used in upcoming matcher code).
- Added "nb" -> "no" conversion in the tables to allow more consistency for code using these tables directly.
- changed to short name used in some methods for type Base so that it consistenly appears as "b" in the documentation.

[mpvl, 2013-09-10 15:10:13]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.text

[r, 2013-09-13 01:34:12]

chunk mismatch; please upload again

[mpvl, 2013-09-13 10:20:24]

Done.


On Fri, Sep 13, 2013 at 3:34 AM, <r@golang.org> wrote:

> chunk mismatch; please upload again
>
>
https://codereview.appspot.**com/13647043/<https://codereview.appspot.com/136...
>

[r, 2013-09-16 03:06:37]

LGTM after tweaks.

https://codereview.appspot.com/13647043/diff/15001/language/language.go
File language/language.go (right):

https://codereview.appspot.com/13647043/diff/15001/language/language.go#newco...
language/language.go:169: // Canonicalize replaces the tag with its canonical
equivalent.
it doesn't really replace it, it returns it. It's a value. how about

Canonicalize returns the canonicalized equivalent of the tag.

there's another occurrence above.

https://codereview.appspot.com/13647043/diff/15001/language/lookup.go
File language/lookup.go (right):

https://codereview.appspot.com/13647043/diff/15001/language/lookup.go#newcode199
language/lookup.go:199: func (b langID) String() string {
b is an odd choice here. i would have thought 'id'.
several more methods below.

[mpvl, 2013-09-16 06:17:17]

https://codereview.appspot.com/13647043/diff/15001/language/language.go
File language/language.go (right):

https://codereview.appspot.com/13647043/diff/15001/language/language.go#newco...
language/language.go:169: // Canonicalize replaces the tag with its canonical
equivalent.
On 2013/09/16 03:06:37, r wrote:
> it doesn't really replace it, it returns it. It's a value. how about
> 
> Canonicalize returns the canonicalized equivalent of the tag.
> 
> there's another occurrence above.

Done.

https://codereview.appspot.com/13647043/diff/15001/language/lookup.go
File language/lookup.go (right):

https://codereview.appspot.com/13647043/diff/15001/language/lookup.go#newcode199
language/lookup.go:199: func (b langID) String() string {
langID is embedded in type Base.  So the public methods from langID show up in
the documentation with this variable name.  I favored a consistent naming of the
public type over an consistent naming of the private type.  I could also rename
all the other internal methods of langID to be consistent if you prefer.

On 2013/09/16 03:06:37, r wrote:
> b is an odd choice here. i would have thought 'id'.
> several more methods below.

[r, 2013-09-16 06:18:27]

i'll leave the renaming decision up to you. in the CL it just looked odd.

[mpvl, 2013-09-23 09:03:25]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b453ef7b57ca&repo=text ***

go.text/language: A few small changes:
- Added Tag methods to Base, Script and Region types to convert them in a proper
tag.
- Factored out part of Canonicalize that does not remake the string (used in
upcoming matcher code).
- Added "nb" -> "no" conversion in the tables to allow more consistency for code
using these tables directly.
- changed to short name used in some methods for type Base so that it
consistenly appears as "b" in the documentation.

R=r
CC=golang-dev
https://codereview.appspot.com/13647043