code review 13611043: net: move mock ICMP into separate file

net: move mock ICMP into separate file

This is in prepartion for fixing issue 6320.

[mikio, 2013-09-07 08:19:18]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-09-07 11:23:01]

On 2013/09/07 08:19:18, mikio wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Did you forget to hg add a file ?

[mikio, 2013-09-07 12:44:15]

On Sat, Sep 7, 2013 at 8:23 PM,  <dave@cheney.net> wrote:

> Did you forget to hg add a file ?

I don't think so.

[mikio, 2013-09-10 07:46:37]

ping

[dave_cheney.net, 2013-09-10 07:55:28]

On 2013/09/10 07:46:37, mikio wrote:
> ping

not lgtm. The description says it's moving code, but all I can see is -400 odd
lines of code. Please explain where the test code mode too.

[mikio, 2013-09-10 08:15:16]

> not lgtm. The description says it's moving code, but all I can see is
> -400 odd lines of code. Please explain where the test code mode too.

I now just see unified diffs of https://codereview.appspot.com/13611043/ say:

Index: src/pkg/net/ipraw_test.go
===================================================================
--- a/src/pkg/net/ipraw_test.go
+++ b/src/pkg/net/ipraw_test.go

and

Index: src/pkg/net/mockicmp_test.go
===================================================================
copy from src/pkg/net/ipraw_test.go
copy to src/pkg/net/mockicmp_test.go
--- a/src/pkg/net/ipraw_test.go
+++ b/src/pkg/net/mockicmp_test.go

also can't see -400 odd lines you are saying. Hm, interesting.

[mikio, 2013-09-10 08:24:32]

On Tue, Sep 10, 2013 at 4:55 PM,  <dave@cheney.net> wrote:

> not lgtm. The description says it's moving code, but all I can see is
> -400 odd lines of code. Please explain where the test code mode too.

Can you please explain what tool are you using and what's the test code mode?

[dave_cheney.net, 2013-09-10 08:26:39]

I am using rietveld.

On Tue, Sep 10, 2013 at 6:24 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> On Tue, Sep 10, 2013 at 4:55 PM,  <dave@cheney.net> wrote:
>
>> not lgtm. The description says it's moving code, but all I can see is
>> -400 odd lines of code. Please explain where the test code mode too.
>
> Can you please explain what tool are you using and what's the test code mode?

[mikio, 2013-09-10 08:35:52]

> I am using rietveld.

Can you please attach a screen capture that describes "-400 odd lines of code"
?

[dave_cheney.net, 2013-09-10 08:38:44]

I added -110 and -288 and came up with a number close to -400 lines.

On Tue, Sep 10, 2013 at 6:35 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
>> I am using rietveld.
>
> Can you please attach a screen capture that describes "-400 odd lines of code"
?

[mikio, 2013-09-10 09:09:12]

Thanks but that is the result of hg cp.

On Sep 10, 2013, at 5:38 PM, Dave Cheney <dave@cheney.net> wrote:

> I added -110 and -288 and came up with a number close to -400 lines.
> 
> On Tue, Sep 10, 2013 at 6:35 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
>>> I am using rietveld.
>> 
>> Can you please attach a screen capture that describes "-400 odd lines of
code" ?

[mikio, 2013-09-10 10:45:58]

> Thanks but that is the result of hg cp.
>
>> I added -110 and -288 and came up with a number close to -400 lines.

Or you'd prefer not to use hg copy?

[dave_cheney.net, 2013-09-11 10:35:30]

On 2013/09/10 10:45:58, mikio wrote:
> > Thanks but that is the result of hg cp.
> >
> >> I added -110 and -288 and came up with a number close to -400 lines.
> 
> Or you'd prefer not to use hg copy?

LGTM. Sorry for my confusion, I understand now what happened, maybe avoid hg
copy in future, it doesn't play well with Rietveld.

[mikio, 2013-09-12 02:59:24]

*** Submitted as https://code.google.com/p/go/source/detail?r=dee2701c645c ***

net: move mock ICMP into separate file

This is in prepartion for fixing issue 6320.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/13611043