Issue 13553050: encoding/json: make omitempty honor IsZero() methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13553050: encoding/json: make omitempty honor IsZero() methods

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by pdp

Modified:
10 years, 7 months ago

Reviewers:

Visibility:
Public.

Description

encoding/json: make omitempty honor IsZero() methods Packages such as time have IsZero() methods, to detect an empty time. By default, encoding/json will still encode the zero value into the bytes. This change has a proposed fix, with tests, for JSON only. If the approach is deemed suitable, then similar fixes will be needed for the other marshalling formats. Affects issue 4357.

Patch Set 1 #

Patch Set 2 : diff -r e47e60d39fc2 https://go.googlecode.com/hg/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -2 lines)			Patch
	M	src/pkg/encoding/json/encode.go	View	1	3 chunks	+25 lines, -2 lines	0 comments	Download
	M	src/pkg/encoding/json/encode_test.go	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download