code review 13441043: go.tools/oracle: change -pos flag syntax from "file pos...

go.tools/oracle: change -pos flag syntax from "file pos-pos" to file:pos-pos.

Pro: no shell quotation needed.
Con: can't be parsed by (the perpetually useless) Scanf.

[adonovan, 2013-08-30 18:38:35]

Hello crawshaw@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[crawshaw1, 2013-09-03 12:59:59]

LGTM

A similar change is needed to oracle.vim.

[dgryski, 2013-09-03 13:39:02]

Le mardi 3 septembre 2013 14:59:59 UTC+2, David Crawshaw a écrit :
>
> LGTM 
>
> A similar change is needed to oracle.vim. 
>

  The position computation for oracle.vim also needs to be updated to take 
encodings into account.  A similar bug was just patched against my 
vim-godef plugin.

  
https://github.com/dgryski/vim-godef/commit/5e52b008c2b33d817cd01c00c7a6cf588...

   Damian

[adonovan, 2013-09-03 14:57:05]

On 2013/09/03 13:39:02, dgryski wrote:
> 
> Le mardi 3 septembre 2013 14:59:59 UTC+2, David Crawshaw a écrit :
> >
> > LGTM 
> >
> > A similar change is needed to oracle.vim. 
> >
> 
>   The position computation for oracle.vim also needs to be updated to take 
> encodings into account.  A similar bug was just patched against my 
> vim-godef plugin.
> 
>   
>
https://github.com/dgryski/vim-godef/commit/5e52b008c2b33d817cd01c00c7a6cf588...

Can you explain this change to me?  Encodings are not relevant when all
computations are done in byte offsets.

(Also: who would use a non-UTF-8 encoding for Go source files?)

[adonovan, 2013-09-03 14:59:01]

*** Submitted as
https://code.google.com/p/go/source/detail?r=07183b5c385c&repo=tools ***

go.tools/oracle: change -pos flag syntax from "file pos-pos" to file:pos-pos.

Pro: no shell quotation needed.
Con: can't be parsed by (the perpetually useless) Scanf.

R=crawshaw, dgryski
CC=golang-dev
https://codereview.appspot.com/13441043