Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1480)

Issue 13436045: code review 13436045: runtime: Smhasher tests of our map hash function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by khr
Modified:
11 years, 8 months ago
Reviewers:
rsc, Charlie Dorian
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: Smhasher tests of our map hash function.

Patch Set 1 #

Patch Set 2 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 5 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 6 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 7 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 8 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 9 : diff -r 6b0ef65315eb https://code.google.com/p/go/ #

Patch Set 10 : diff -r 2a5486440b06 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -0 lines) Patch
M src/pkg/runtime/alg.c View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M src/pkg/runtime/export_test.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
A src/pkg/runtime/hash_test.go View 1 2 3 4 5 6 7 8 1 chunk +512 lines, -0 lines 0 comments Download

Messages

Total messages: 4
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 8 months ago (2013-09-06 21:10:51 UTC) #1
rsc
LGTM
11 years, 8 months ago (2013-09-06 22:08:23 UTC) #2
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=3338bbc9c09b *** runtime: Smhasher tests of our map hash function. R=golang-dev, rsc ...
11 years, 8 months ago (2013-09-06 23:23:49 UTC) #3
Charlie Dorian
11 years, 8 months ago (2013-09-07 02:51:48 UTC) #4
Message was sent while issue was closed.
On 2013/09/06 23:23:49, khr wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=3338bbc9c09b ***
> 
> runtime: Smhasher tests of our map hash function.
> 
> R=golang-dev, rsc
> CC=golang-dev
> https://codereview.appspot.com/13436045

You could speed up, a little, hash_test.go: 

401 for c = 0.0; math.Pow(math.Erf(c/math.Sqrt(2)), float64(N)) < .99; c += .1 {
402 }

by replacing the function math.Sqrt(2) with the constant math.Sqrt2.

-- Charlie
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b