Issue 13422048: cmd/cgo: conservatively label all cgo function arguments...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13422048: cmd/cgo: conservatively label all cgo function arguments... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by minux1

Modified:
10 years, 7 months ago

Reviewers:

Visibility:
Public.

Description

cmd/cgo: conservatively label all cgo function arguments as pointers. This is a simple workaround for Go 1.2, we can and should do better. Fixes issue 6397.

Patch Set 1 #

Patch Set 2 : diff -r d1b8c87a7b3d https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/cmd/cgo/out.go	View	1	1 chunk	+10 lines, -1 line	0 comments	Download