Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(638)

Issue 13401045: state: reinstate accidentally-dropped tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by fwereade
Modified:
10 years, 7 months ago
Reviewers:
mp+183189, rog
Visibility:
Public.

Description

state: reinstate accidentally-dropped tests Aside from removal of the tests for the Joined field (which is no longer sent, because it's redundant (preexisting change)), this was a mechanical rename job from the original. It's reassuring to observe that behaviour had not otherwise changed detectably in the interim. https://code.launchpad.net/~fwereade/juju-core/reinstate-relation-watch-tests/+merge/183189 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/relationunit_test.go View 4 chunks +484 lines, -3 lines 0 comments Download

Messages

Total messages: 2
fwereade
Please take a look.
10 years, 7 months ago (2013-08-30 14:30:20 UTC) #1
rog
10 years, 7 months ago (2013-08-30 14:31:53 UTC) #2
On 2013/08/30 14:30:20, fwereade wrote:
> Please take a look.

assuming this is mechanical and pre-reviewed, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b