Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 13352055: code review 13352055: go.crypto/ssh: separate kex algorithms into kexAlgorith... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by hanwen-google
Modified:
6 years, 1 month ago
Reviewers:
agl1, jpsugar
CC:
agl1, dfc, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: separate kex algorithms into kexAlgorithm class. Adds readPacket() to conn, and renames conn to packetConn. Key exchanges operate on packetConn, so they can be unittested.

Patch Set 1 #

Patch Set 2 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Total comments: 4

Patch Set 3 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Total comments: 6

Patch Set 5 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -533 lines) Patch
M ssh/channel.go View 1 4 chunks +7 lines, -7 lines 0 comments Download
M ssh/client.go View 1 2 10 chunks +27 lines, -170 lines 0 comments Download
M ssh/client_auth.go View 1 2 17 chunks +24 lines, -24 lines 0 comments Download
M ssh/common.go View 1 4 chunks +0 lines, -54 lines 0 comments Download
A ssh/kex.go View 1 2 3 4 5 1 chunk +387 lines, -0 lines 0 comments Download
M ssh/kex_test.go View 1 2 1 chunk +57 lines, -68 lines 0 comments Download
M ssh/server.go View 1 2 3 4 5 7 chunks +21 lines, -205 lines 0 comments Download
M ssh/transport.go View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9
hanwen-google
Hello agl@golang.org, jpsugar@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
6 years, 1 month ago (2013-09-23 13:32:00 UTC) #1
hanwen-google
I originally also wanted to unittest user auth separately, hence the changes to client_auth.go, but ...
6 years, 1 month ago (2013-09-23 13:36:33 UTC) #2
jpsugar
https://codereview.appspot.com/13352055/diff/3001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/13352055/diff/3001/ssh/client_auth.go#newcode84 ssh/client_auth.go:84: auth(session []byte, user string, t packetConn, rand io.Reader) (bool, ...
6 years, 1 month ago (2013-09-23 21:19:05 UTC) #3
hanwen-google
https://codereview.appspot.com/13352055/diff/3001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/13352055/diff/3001/ssh/client_auth.go#newcode84 ssh/client_auth.go:84: auth(session []byte, user string, t packetConn, rand io.Reader) (bool, ...
6 years, 1 month ago (2013-09-24 12:55:24 UTC) #4
agl1
LGTM with nits. https://codereview.appspot.com/13352055/diff/10001/ssh/kex.go File ssh/kex.go (right): https://codereview.appspot.com/13352055/diff/10001/ssh/kex.go#newcode1 ssh/kex.go:1: package ssh Copyright comment. https://codereview.appspot.com/13352055/diff/10001/ssh/kex.go#newcode36 ssh/kex.go:36: ...
6 years, 1 month ago (2013-09-24 15:11:11 UTC) #5
hanwen-google
https://codereview.appspot.com/13352055/diff/10001/ssh/kex.go File ssh/kex.go (right): https://codereview.appspot.com/13352055/diff/10001/ssh/kex.go#newcode1 ssh/kex.go:1: package ssh On 2013/09/24 15:11:11, agl1 wrote: > Copyright ...
6 years, 1 month ago (2013-09-24 15:28:25 UTC) #6
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=ca17ccb492a0&repo=crypto *** go.crypto/ssh: separate kex algorithms into kexAlgorithm class. Adds readPacket() to ...
6 years, 1 month ago (2013-09-24 16:26:41 UTC) #7
jpsugar
LGTM (for the record)
6 years, 1 month ago (2013-09-24 16:28:04 UTC) #8
hanwen-google
6 years, 1 month ago (2013-09-24 16:46:30 UTC) #9
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b