Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 13343045: code review 13343045: go.crypto/curve25519: rewrite generic code to be consta... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by agl1
Modified:
10 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.crypto/curve25519: rewrite generic code to be constant time. Previously curve25519 contained a constant-time, optimised amd64 implementation and a generic implemenation that used math/big and that was not constant-time. This change contains a Go port of the public domain, "ref10" implementation from SUPERCOP. This has the advantage of being faster and constant-time.

Patch Set 1 #

Patch Set 2 : diff -r 69c3cecb8b4f https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 69c3cecb8b4f https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 8cbc665c1b38 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+816 lines, -111 lines) Patch
M curve25519/curve25519.go View 1 1 chunk +816 lines, -111 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
10 years, 7 months ago (2013-08-31 14:46:25 UTC) #1
bradfitz
LGTM
10 years, 7 months ago (2013-08-31 18:30:51 UTC) #2
agl1
10 years, 6 months ago (2013-09-03 13:31:37 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=ca4f5d45cddf&repo=crypto ***

go.crypto/curve25519: rewrite generic code to be constant time.

Previously curve25519 contained a constant-time, optimised amd64 implementation
and
a generic implemenation that used math/big and that was not constant-time.

This change contains a Go port of the public domain, "ref10" implementation from
SUPERCOP. This has the advantage of being faster and constant-time.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13343045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b