Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(488)

Issue 13328044: code review 13328044: go.tools/oracle: address reviewer suggestions from CL 9... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by adonovan
Modified:
10 years, 7 months ago
Reviewers:
crawshaw1
CC:
crawshaw1, golang-dev
Visibility:
Public.

Description

go.tools/oracle: address reviewer suggestions from CL 9502043 (I made these changes in the wrong workspace.)

Patch Set 1 #

Patch Set 2 : diff -r 28b59754195f https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 28b59754195f https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 850bd7b6f2ee https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M oracle/oracle.go View 1 1 chunk +1 line, -1 line 0 comments Download
M oracle/peers.go View 1 2 2 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 4
adonovan
Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 7 months ago (2013-08-28 18:08:01 UTC) #1
crawshaw1
LGTM
10 years, 7 months ago (2013-08-28 18:46:32 UTC) #2
adonovan
*** Submitted as https://code.google.com/p/go/source/detail?r=7c53df5c9267&repo=tools *** go.tools/oracle: address reviewer suggestions from CL 9502043 (I made these ...
10 years, 7 months ago (2013-08-30 01:37:01 UTC) #3
adonovan
10 years, 7 months ago (2013-08-30 01:41:34 UTC) #4
Message was sent while issue was closed.
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b