Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(535)

Issue 13301047: Create a new option for GUI debug mode.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
mp+185307, rharding
Visibility:
Public.

Description

Create a new option for GUI debug mode. Setting the juju-gui-debug option to true is now possible to serve the GUI source files individually (uncompressed). As a consequence, setting staging to true no longer activates debug mode as a side effect. QA: - deploy the GUI from this branch (make deploy); - run `juju set juju-gui juju-gui-debug=true`, wait a minute and then verify the uncompressed files are served by Apache; - run `juju set juju-gui builtin-server=true`, wait a minute and then verify the uncompressed files are correctly served by the Tornado server (tailf /var/log/upstart/guiserver.log can help). https://code.launchpad.net/~frankban/charms/precise/juju-gui/separate-staging-debug/+merge/185307 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Create a new option for GUI debug mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 2 chunks +8 lines, -3 lines 0 comments Download
M hooks/backend.py View 3 chunks +3 lines, -3 lines 0 comments Download
M hooks/utils.py View 2 chunks +2 lines, -2 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_utils.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 6 months ago (2013-09-12 15:52:17 UTC) #1
rharding
LGTM qa ok. Thanks so much for this!
10 years, 6 months ago (2013-09-12 16:51:37 UTC) #2
frankban
*** Submitted: Create a new option for GUI debug mode. Setting the juju-gui-debug option to ...
10 years, 6 months ago (2013-09-12 16:59:55 UTC) #3
frankban
10 years, 6 months ago (2013-09-12 17:04:38 UTC) #4
Hi Rick, thanks for the review!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b