code review 13277044: go.crypto/openpgp/packet: use minimal interface for Ser...

go.crypto/openpgp/packet: use minimal interface for SerializeSignaturePrefix.

Only an io.Writer is needed in this case.

Fixes issue 6035.

[agl1, 2013-08-30 14:23:04]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/

[bradfitz, 2013-08-30 14:23:48]

LGTM
 On Aug 30, 2013 7:23 AM, <agl@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**crypto/<https://code.google.com/p/go.crypto/>
>
>
> Description:
> go.crypto/openpgp/packet: use minimal interface for
> SerializeSignaturePrefix.
>
> Only an io.Writer is needed in this case.
>
> Fixes issue 6035.
>
> Please review this at
https://codereview.appspot.**com/13277044/<https://codereview.appspot.com/132...
>
> Affected files:
>   M openpgp/packet/public_key.go
>
>
> Index: openpgp/packet/public_key.go
> ==============================**==============================**=======
> --- a/openpgp/packet/public_key.go
> +++ b/openpgp/packet/public_key.go
> @@ -340,7 +340,7 @@
>  // SerializeSignaturePrefix writes the prefix for this public key to the
> given Writer.
>  // The prefix is used when calculating a signature over this public key.
> See
>  // RFC 4880, section 5.2.4.
> -func (pk *PublicKey) SerializeSignaturePrefix(h hash.Hash) {
> +func (pk *PublicKey) SerializeSignaturePrefix(h io.Writer) {
>         var pLength uint16
>         switch pk.PubKeyAlgo {
>         case PubKeyAlgoRSA, PubKeyAlgoRSAEncryptOnly,
> PubKeyAlgoRSASignOnly:
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[agl1, 2013-08-30 14:38:59]

*** Submitted as
https://code.google.com/p/go/source/detail?r=8cbc665c1b38&repo=crypto ***

go.crypto/openpgp/packet: use minimal interface for SerializeSignaturePrefix.

Only an io.Writer is needed in this case.

Fixes issue 6035.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13277044