Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1086)

Issue 132680044: code review 132680044: mime: added functions concerning MIME headers and creat...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by alexcesaro
Modified:
8 years, 11 months ago
Reviewers:
CC:
golang-codereviews, ruiu, bradfitz, josharian, minux
Visibility:
Public.

Description

mime: added functions concerning MIME headers and created the mime/quotedprintable package. Fixes issue 4943. Fixes issue 4687. Fixes issue 7079. Fixes issue 7140.

Patch Set 1 #

Patch Set 2 : diff -r 938ecc995cbca35db65ef45c0276720bc5349036 https://code.google.com/p/go #

Patch Set 3 : diff -r 80df44cfde2ec44b8c84059e1066fda4728fa5fa https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1182 lines, -149 lines) Patch
M src/go/build/deps_test.go View 1 2 chunks +38 lines, -37 lines 0 comments Download
A src/mime/header.go View 1 1 chunk +409 lines, -0 lines 0 comments Download
A src/mime/header_test.go View 1 1 chunk +115 lines, -0 lines 0 comments Download
A src/mime/internal/quotedprintable.go View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M src/mime/multipart/multipart.go View 1 2 chunks +2 lines, -1 line 0 comments Download
A src/mime/quotedprintable/quotedprintable.go View 1 1 chunk +222 lines, -0 lines 0 comments Download
A src/mime/quotedprintable/quotedprintable_test.go View 1 1 chunk +313 lines, -0 lines 0 comments Download
M src/net/mail/message.go View 1 2 4 chunks +30 lines, -109 lines 0 comments Download
M src/net/mail/message_test.go View 1 2 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7
alexcesaro
I had to delete the old CL (https://codereview.appspot.com/101330049/) and create a new one because of ...
9 years, 7 months ago (2014-09-15 16:18:34 UTC) #1
alexcesaro
Hello golang-codereviews@googlegroups.com, ruiu@google.com, bradfitz@golang.org, josharian@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...
9 years, 6 months ago (2014-10-15 09:51:08 UTC) #2
alexcesaro
What should I do with this CL? Send it again on Gerrit? On Wed, Oct ...
9 years, 4 months ago (2014-12-16 18:11:26 UTC) #3
josharian
Yes, once the tree reopens. On Tuesday, December 16, 2014, Alexandre Cesaro <alexandre.cesaro@gmail.com> wrote: > ...
9 years, 4 months ago (2014-12-16 18:13:08 UTC) #4
bradfitz
It should be within 24 hours. Watch or poll golang-dev for the announcement. On Wed, ...
9 years, 4 months ago (2014-12-17 06:14:23 UTC) #5
minux
On Wed, Dec 17, 2014 at 1:14 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > > It ...
9 years, 4 months ago (2014-12-17 06:19:38 UTC) #6
gobot
9 years, 4 months ago (2014-12-19 05:12:16 UTC) #7
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/132680044 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b