Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(757)

Issue 132560043: code review 132560043: net: fix parsing literal IPv6 address with zone identif... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by mikio
Modified:
4 years, 9 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

net: fix parsing literal IPv6 address with zone identifier in builtin dns stub resolver Fixes issue 8619.

Patch Set 1 : diff -r b25fb560b4f01dda2ff89df365ec0b085725d734 https://code.google.com/p/go #

Patch Set 2 : diff -r 23e48d4f30661630cff46dd356ca9ea3916365c5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/pkg/net/dnsconfig_unix.go View 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/net/dnsconfig_unix_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/testdata/resolv.conf View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
4 years, 9 months ago (2014-09-04 01:15:33 UTC) #1
iant
LGTM
4 years, 9 months ago (2014-09-04 03:40:11 UTC) #2
mikio
4 years, 9 months ago (2014-09-04 03:54:05 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=61ca284cc8aa ***

net: fix parsing literal IPv6 address with zone identifier in builtin dns stub
resolver

Fixes issue 8619.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/132560043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b