Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1376)

Issue 132380043: Change CircularQueueConstructor to accept an allocator rather than a MemoryNotifierInterface. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by chrisha
Modified:
9 years, 7 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Change CircularQueueConstructor to accept an allocator rather than a MemoryNotifierInterface. This makes it more generic, and consistent with use elsewhere. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M syzygy/agent/asan/circular_queue.h View 1 chunk +2 lines, -7 lines 0 comments Download
M syzygy/agent/asan/circular_queue_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M syzygy/agent/asan/circular_queue_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M syzygy/agent/asan/heaps/zebra_block_heap.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
chrisha
PTAL
9 years, 7 months ago (2014-08-28 19:46:28 UTC) #1
Sébastien Marchand
lgtm.
9 years, 7 months ago (2014-08-28 19:51:49 UTC) #2
chrisha
Thanks, committing.
9 years, 7 months ago (2014-08-28 19:52:47 UTC) #3
chrisha
9 years, 7 months ago (2014-08-28 19:58:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2279 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b