Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16660)

Issue 13231044: code review 13231044: go.tools/oracle: fix build on darwin (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by r
Modified:
10 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.tools/oracle: fix build on darwin diff -u3: the 3 is redundant and an error on darwin; redundant and unnecessary on linux.

Patch Set 1 #

Patch Set 2 : diff -r 8638a51252a3 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M oracle/oracle_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 7 months ago (2013-08-29 04:08:26 UTC) #1
bradfitz
LGTM On Wed, Aug 28, 2013 at 9:08 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
10 years, 7 months ago (2013-08-29 04:13:28 UTC) #2
r
10 years, 7 months ago (2013-08-29 04:31:48 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=f841df44e459&repo=tools ***

go.tools/oracle: fix build on darwin

diff -u3: the 3 is redundant and an error on darwin; redundant and unnecessary
on linux.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13231044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b