Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(299)

Issue 132280043: Issue 3299: better alignment with PaperColumn parent

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by janek
Modified:
9 years, 5 months ago
Reviewers:
Keith, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3299: better alignment with PaperColumn parent PaperColumns are the objects that define where a musical moment "happens" on the staff horizontally. However, the noteheads aren't center-aligned on PaperColumns - according to notation rules they are left-aligned. Because of that an object centered on a notehead is not actually centered on the PaperColumn, which results in a discrepancy between objects attached to NoteHeads and PaperColumns. This commit fixes that by introducing a placeholder extent which is used for aligning such grobs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -49 lines) Patch
M Documentation/notation/vocal.itely View 1 chunk +1 line, -0 lines 0 comments Download
A input/regression/alignment-of-grobs-attached-to-paper-column.ly View 1 chunk +133 lines, -0 lines 0 comments Download
D input/regression/unassociated-lyrics-alignment.ly View 1 chunk +0 lines, -44 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +3 lines, -1 line 0 comments Download
M lily/self-alignment-interface.cc View 1 chunk +23 lines, -4 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
janek
Please review. I hope that the regtest (see output here https://code.google.com/p/lilypond/issues/detail?id=3299#c9) and commit message are ...
9 years, 7 months ago (2014-08-27 21:23:59 UTC) #1
dak
On 2014/08/27 21:23:59, janek wrote: > Please review. I hope that the regtest (see output ...
9 years, 7 months ago (2014-08-27 22:01:03 UTC) #2
Keith
LGTM in principle, but expect to spend a lot of time figuring out how to ...
9 years, 7 months ago (2014-08-28 05:46:28 UTC) #3
janek
9 years, 5 months ago (2014-10-05 15:33:25 UTC) #4
Hi all,

sorry for lack of updates... i got absorbed by Trunkne Lied project we're doing
with Urs (http://lilypondblog.org/2014/10/crowd-engraving-picking-up-speed/).

I have recently found a way to get previous notecolumn, which should allow me to
write this in a cleaner way, but i'll need some spare time to finish this new
approach.  I think that this version of the patch is not optimal and should be
abandoned, so i'll mark the issue in google tracker as needs_work.

I expect that i'll get back to this in 3-4 weeks.

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b