Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(813)

Issue 13141044: openpgp/packet: Parse and serialize ECC key material (R...

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by cmars
Modified:
10 years, 7 months ago
Reviewers:
agl1
CC:
agl1, golang-dev
Visibility:
Public.

Description

openpgp/packet: Parse and serialize ECC key material (RFC 6637). Support ECDSA signature verification.

Patch Set 1 #

Patch Set 2 : diff -r 1e7a3e301825 https://code.google.com/p/go.crypto #

Total comments: 54

Patch Set 3 : diff -r 5c2f63878818 https://code.google.com/p/go.crypto #

Total comments: 4

Patch Set 4 : diff -r 5c2f63878818 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -6 lines) Patch
M openpgp/packet/packet.go View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M openpgp/packet/public_key.go View 1 2 3 7 chunks +174 lines, -2 lines 0 comments Download
M openpgp/packet/public_key_test.go View 1 2 3 chunks +103 lines, -0 lines 0 comments Download
M openpgp/packet/signature.go View 1 6 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 9
cmars
10 years, 7 months ago (2013-08-22 03:02:41 UTC) #1
cmars
10 years, 7 months ago (2013-08-26 04:15:16 UTC) #2
agl1
https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go File openpgp/packet/public_key.go (right): https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go#newcode27 openpgp/packet/public_key.go:27: var curveOidP256 []byte = []byte{0x2A, 0x86, 0x48, 0xCE, 0x3D, ...
10 years, 7 months ago (2013-08-26 14:55:20 UTC) #3
agl1
Note: you've uploaded a new patch set to this change, but not published any replies. ...
10 years, 7 months ago (2013-08-29 14:39:47 UTC) #4
cmars
On 2013/08/29 14:39:47, agl1 wrote: > Note: you've uploaded a new patch set to this ...
10 years, 7 months ago (2013-08-29 14:49:39 UTC) #5
cmars
PTAL https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go File openpgp/packet/public_key.go (right): https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go#newcode27 openpgp/packet/public_key.go:27: var curveOidP256 []byte = []byte{0x2A, 0x86, 0x48, 0xCE, ...
10 years, 7 months ago (2013-08-29 15:58:49 UTC) #6
agl1
LGTM with nits. https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go File openpgp/packet/public_key.go (right): https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go#newcode230 openpgp/packet/public_key.go:230: pk.PublicKey, err = pk.ec.newECDSA() On 2013/08/29 ...
10 years, 7 months ago (2013-08-29 16:40:23 UTC) #7
cmars
PTAL https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go File openpgp/packet/public_key.go (right): https://codereview.appspot.com/13141044/diff/3001/openpgp/packet/public_key.go#newcode230 openpgp/packet/public_key.go:230: pk.PublicKey, err = pk.ec.newECDSA() On 2013/08/29 16:40:23, agl1 ...
10 years, 7 months ago (2013-08-29 17:14:42 UTC) #8
agl1
10 years, 7 months ago (2013-08-29 21:10:20 UTC) #9
*** Submitted as
https://code.google.com/p/go/source/detail?r=4dbd0e989373&repo=crypto ***

openpgp/packet: Parse and serialize ECC key material (RFC 6637).

Support ECDSA signature verification.

R=agl
CC=golang-dev
https://codereview.appspot.com/13141044

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b