code review 13050043: net: fix garbage connection close in dual stack tests

net: fix garbage connection close in dual stack tests

This may possibly be the root cause of flaky dual stack tests.

Update issue 4176
Update issue 5001

[mikio, 2013-08-16 11:57:02]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-08-17 02:48:06]

LGTM

I think.

https://codereview.appspot.com/13050043/diff/6001/src/pkg/net/unicast_posix_t...
File src/pkg/net/unicast_posix_test.go (right):

https://codereview.appspot.com/13050043/diff/6001/src/pkg/net/unicast_posix_t...
src/pkg/net/unicast_posix_test.go:169: // to a test listener with various
address families, differnet
different

https://codereview.appspot.com/13050043/diff/6001/src/pkg/net/unicast_posix_t...
src/pkg/net/unicast_posix_test.go:346: func checkDualStackSecondListener(t
*testing.T, net, laddr string, xerr, err error, l interface{}) {
this function signature sucks or is at best confusing. could you document it
and/or rename some variables?

[mikio, 2013-08-17 03:04:41]

On Sat, Aug 17, 2013 at 11:48 AM,  <bradfitz@golang.org> wrote:

> checkDualStackSecondListener(t *testing.T, net, laddr string, xerr, err
> error, l interface{}) {
> this function signature sucks or is at best confusing. could you
> document it and/or rename some variables?

will do in another CL later.
yup, unicast_posix_test.go and server_test.go are completely
disaster but we need them until go 1.2 lands.

[mikio, 2013-08-17 04:41:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=6d2a2628859d ***

net: fix garbage connection close in dual stack tests

This may possibly be the root cause of flaky dual stack tests.

Update issue 4176
Update issue 5001

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13050043