Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(927)

Issue 13050043: code review 13050043: net: fix garbage connection close in dual stack tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by mikio
Modified:
5 years, 10 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: fix garbage connection close in dual stack tests This may possibly be the root cause of flaky dual stack tests. Update issue 4176 Update issue 5001

Patch Set 1 #

Patch Set 2 : diff -r c1730ab629cd https://code.google.com/p/go #

Patch Set 3 : diff -r c1730ab629cd https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 8d94debb8662 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/pkg/net/unicast_posix_test.go View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 10 months ago (2013-08-16 11:57:02 UTC) #1
bradfitz
LGTM I think. https://codereview.appspot.com/13050043/diff/6001/src/pkg/net/unicast_posix_test.go File src/pkg/net/unicast_posix_test.go (right): https://codereview.appspot.com/13050043/diff/6001/src/pkg/net/unicast_posix_test.go#newcode169 src/pkg/net/unicast_posix_test.go:169: // to a test listener with ...
5 years, 10 months ago (2013-08-17 02:48:06 UTC) #2
mikio
On Sat, Aug 17, 2013 at 11:48 AM, <bradfitz@golang.org> wrote: > checkDualStackSecondListener(t *testing.T, net, laddr ...
5 years, 10 months ago (2013-08-17 03:04:41 UTC) #3
mikio
5 years, 10 months ago (2013-08-17 04:41:04 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=6d2a2628859d ***

net: fix garbage connection close in dual stack tests

This may possibly be the root cause of flaky dual stack tests.

Update issue 4176
Update issue 5001

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13050043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b