Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3242)

Issue 130390045: Add protobuf library to third_party. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by chrisha
Modified:
9 years, 7 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add protobuf library to third_party. This is going to be used by SyzyASAN for enhanced crash reporting data. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2270

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -27 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS.syzygy View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/protobuf/LICENSE View 1 chunk +1 line, -6 lines 0 comments Download
A third_party/protobuf/README.thirdparty View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/protobuf/config.h View 1 chunk +16 lines, -6 lines 0 comments Download
A third_party/protobuf/protobuf.gyp View 1 chunk +206 lines, -0 lines 0 comments Download
A + third_party/protobuf/protobuf_common.gypi View 1 chunk +28 lines, -15 lines 0 comments Download
A third_party/protobuf/protobuf_lite.gypi View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 5
chrisha
PTAL
9 years, 7 months ago (2014-08-21 18:32:27 UTC) #1
chrisha
Ping?
9 years, 7 months ago (2014-08-25 13:58:09 UTC) #2
Sébastien Marchand
lgtm, sorry for the delay. https://codereview.appspot.com/130390045/diff/20001/DEPS.syzygy File DEPS.syzygy (right): https://codereview.appspot.com/130390045/diff/20001/DEPS.syzygy#newcode96 DEPS.syzygy:96: # This brings in ...
9 years, 7 months ago (2014-08-25 15:06:19 UTC) #3
chrisha
Thanks, committing. https://codereview.appspot.com/130390045/diff/20001/DEPS.syzygy File DEPS.syzygy (right): https://codereview.appspot.com/130390045/diff/20001/DEPS.syzygy#newcode96 DEPS.syzygy:96: # This brings in protobuf, used by ...
9 years, 7 months ago (2014-08-25 15:07:34 UTC) #4
chrisha
9 years, 7 months ago (2014-08-25 15:09:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 2270 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b