Issue 13007046: Fixes bad tests that landed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13007046: Fixes bad tests that landed.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rharding

Modified:
10 years, 8 months ago

Reviewers:
mp+181871, jeff.pihach

Visibility:
Public.

Description

Fixes bad tests that landed. - Not sure how they passed, but constraints is not passed in and needs to be accounted for in tests. https://code.launchpad.net/~rharding/juju-gui/test-fail-wtf/+merge/181871 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes bad tests that landed. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/test_env_go.js	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

LGTM - self reviewing trivial to get tests passing (hopefully) again.

10 years, 8 months ago (2013-08-23 17:11:25 UTC) #2

rharding

10 years, 8 months ago (2013-08-23 17:16:34 UTC) #4

*** Submitted:

Fixes bad tests that landed.

- Not sure how they passed, but constraints is not passed in and needs to be
accounted for in tests.

R=
CC=
https://codereview.appspot.com/13007046

Expand All Messages | Collapse All Messages