Issue 12983046: code review 12983046: crypto/ssh: Handle msgUserAuthBanner during keyboard-in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12983046: code review 12983046: crypto/ssh: Handle msgUserAuthBanner during keyboard-in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by jpsugar

Modified:
10 years, 7 months ago

Reviewers:
agl1

CC:
agl1, golang-dev

Visibility:
Public.

Description

crypto/ssh: Handle msgUserAuthBanner during keyboard-interactive auth.

Patch Set 2 : diff -r 1e7a3e301825 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 1e7a3e301825 https://code.google.com/p/go.crypto #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ssh/client_auth.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jpsugar

Hello agl@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

10 years, 7 months ago (2013-08-26 19:28:30 UTC) #1

agl1

LGTM. I presume that we were previously aborting when we received banners.

10 years, 7 months ago (2013-08-27 15:23:15 UTC) #2

agl1

*** Submitted as https://code.google.com/p/go/source/detail?r=cbce6bcde600&repo=crypto *** crypto/ssh: Handle msgUserAuthBanner during keyboard-interactive auth. R=agl, golang-dev CC=golang-dev https://codereview.appspot.com/12983046 ...

10 years, 7 months ago (2013-08-27 15:23:48 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages