Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1252)

Issue 12966045: openpgp/packet: Add user attribute packet support.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by cmars
Modified:
10 years, 7 months ago
Reviewers:
CC:
agl1, golang-dev
Visibility:
Public.

Description

openpgp/packet: Add user attribute packet support. Supports JPEG images as well as free-form arbitrary subpacket data in user attributes (RFC 4880, Section 5.12) (updated per agl feedback)

Patch Set 1 #

Patch Set 2 : diff -r 1e7a3e301825 https://code.google.com/p/go.crypto #

Total comments: 21

Patch Set 3 : diff -r 1e7a3e301825 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -18 lines) Patch
M openpgp/packet/opaque.go View 1 2 3 chunks +33 lines, -18 lines 0 comments Download
M openpgp/packet/packet.go View 1 2 chunks +3 lines, -0 lines 0 comments Download
A openpgp/packet/userattribute.go View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A openpgp/packet/userattribute_test.go View 1 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 5
cmars
10 years, 7 months ago (2013-08-22 02:58:17 UTC) #1
cmars
10 years, 7 months ago (2013-08-26 04:16:12 UTC) #2
agl1
https://codereview.appspot.com/12966045/diff/3001/openpgp/packet/opaque.go File openpgp/packet/opaque.go (right): https://codereview.appspot.com/12966045/diff/3001/openpgp/packet/opaque.go#newcode156 openpgp/packet/opaque.go:156: _, err = w.Write(buf) if _, err = w.Write(buf); ...
10 years, 7 months ago (2013-08-26 14:32:15 UTC) #3
cmars
PTAL https://codereview.appspot.com/12966045/diff/3001/openpgp/packet/opaque.go File openpgp/packet/opaque.go (right): https://codereview.appspot.com/12966045/diff/3001/openpgp/packet/opaque.go#newcode156 openpgp/packet/opaque.go:156: _, err = w.Write(buf) On 2013/08/26 14:32:15, agl1 ...
10 years, 7 months ago (2013-08-28 05:43:28 UTC) #4
agl1
10 years, 7 months ago (2013-08-28 15:02:38 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=5c2f63878818&repo=crypto ***

go.crypto/openpgp/packet: Add user attribute packet support.

Supports JPEG images as well as free-form arbitrary subpacket data in
user attributes (RFC 4880, Section 5.12)

R=agl
CC=golang-dev
https://codereview.appspot.com/12966045

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b