Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(792)

Issue 129150043: code review 129150043: oauth: make Google work again (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by bradfitz
Modified:
9 years, 8 months ago
Reviewers:
adg, mtj1
CC:
adg, jbd, golang-codereviews
Visibility:
Public.

Description

oauth: make Google work again Google apparently doesn't implement the spec properly? Confirmed Camlistore's picasa importer works again after this, and Camlistore's foursquare importer continues to work. Going forward, we should build a manual integration test for a dozen providers. Ideally.

Patch Set 1 #

Patch Set 2 : diff -r f06a85362aa5d1ca289f21df424b9c8d8f3c5356 https://code.google.com/p/goauth2 #

Patch Set 3 : diff -r f06a85362aa5d1ca289f21df424b9c8d8f3c5356 https://code.google.com/p/goauth2 #

Patch Set 4 : diff -r f06a85362aa5d1ca289f21df424b9c8d8f3c5356 https://code.google.com/p/goauth2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M oauth/oauth.go View 1 2 3 1 chunk +27 lines, -8 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello adg@golang.org, jbd@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2
9 years, 8 months ago (2014-08-14 00:16:51 UTC) #1
adg
LGTM
9 years, 8 months ago (2014-08-14 00:18:46 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/goauth2/source/detail?r=eab72654f295 *** oauth: make Google work again Google apparently doesn't implement the ...
9 years, 8 months ago (2014-08-14 00:19:15 UTC) #3
bradfitz
Submitting with better comment. On Wed, Aug 13, 2014 at 5:18 PM, <adg@golang.org> wrote: > ...
9 years, 8 months ago (2014-08-14 00:19:19 UTC) #4
mtj1
9 years, 8 months ago (2014-08-14 00:26:05 UTC) #5
Nearly two billion people are relieved that Google is working again.


On Wed, Aug 13, 2014 at 5:19 PM, Brad Fitzpatrick <bradfitz@golang.org>
wrote:

> Submitting with better comment.
>
>
>
> On Wed, Aug 13, 2014 at 5:18 PM, <adg@golang.org> wrote:
>
>> LGTM
>>
>> https://codereview.appspot.com/129150043/
>>
>
>  --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Michael T. Jones | Chief Technology Advocate  | mtj@google.com
<mtj@google.com> |  +1 650-335-5765*
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b