Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 129078: add support for precompilation-enabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by woodie
Modified:
10 months, 3 weeks ago
Reviewers:
do_not_use
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : lazyHandles: not worth the effort #

Total comments: 1

Patch Set 3 : new gems for 1.2.6 #

Patch Set 4 : new files for 1.2.6 #

Total comments: 1

Patch Set 5 : We need to repackage with appengine-rack #

Patch Set 6 : Update dev_appserver to use the new agent jar. #

Patch Set 7 : Update google-appengine gem #

Patch Set 8 : new SDK, but we need listener to LoadOnFirstRequest #

Total comments: 1

Patch Set 9 : package the LazyContextListener #

Patch Set 10 : Add LazyContextListener #

Total comments: 6

Patch Set 11 : move the java files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -18 lines) Patch
M appengine-rack/Rakefile View 1 chunk +1 line, -1 line 0 comments Download
M appengine-rack/lib/appengine-rack.rb View 1 4 chunks +9 lines, -1 line 0 comments Download
M appengine-sdk/appengine-sdk.erb View 2 chunks +2 lines, -1 line 0 comments Download
M appengine-tools/Rakefile View 1 chunk +1 line, -1 line 0 comments Download
M appengine-tools/lib/appengine-tools/bundler.rb View 1 chunk +1 line, -2 lines 0 comments Download
M appengine-tools/lib/appengine-tools/dev_appserver.rb View 1 chunk +3 lines, -0 lines 0 comments Download
M appengine-tools/lib/appengine-tools/update_check.rb View 3 chunks +4 lines, -4 lines 0 comments Download
M appengine-tools/lib/appengine-tools/web-xml.rb View 8 1 chunk +1 line, -1 line 0 comments Download
M google-appengine/Rakefile View 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M jruby-abridged/Rakefile View 9 10 1 chunk +6 lines, -1 line 0 comments Download
M jruby-abridged/lib/appengine-jruby-jars.rb View 2 chunks +2 lines, -2 lines 0 comments Download
A jruby-abridged/src/LazyApplicationFactory.class View Binary file 0 comments Download
A jruby-abridged/src/LazyContextListener.class View Binary file 0 comments Download
A jruby-abridged/src/build.sh View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7
woodie
this seems to work http://codereview.appspot.com/129078/diff/1/3 File appengine-rack/lib/appengine-rack.rb (right): http://codereview.appspot.com/129078/diff/1/3#newcode97 Line 97: attr_accessor :application, :inbound_services, :precompilation_enabled ...
13 years, 1 month ago (2009-10-14 02:44:10 UTC) #1
woodie
http://codereview.appspot.com/129078/diff/1004/6 File appengine-rack/lib/appengine-rack.rb (right): http://codereview.appspot.com/129078/diff/1004/6#newcode106 Line 106: # 'jruby.compile.lazyHandles' => true, I cannot imagine that ...
13 years, 1 month ago (2009-10-14 05:50:34 UTC) #2
woodie
you sdk rakefile is remarkable http://codereview.appspot.com/129078/diff/1006/2009 File appengine-rack/lib/appengine-rack.rb (right): http://codereview.appspot.com/129078/diff/1006/2009#newcode106 Line 106: # 'jruby.compile.lazyHandles' => ...
13 years, 1 month ago (2009-10-15 08:30:19 UTC) #3
woodie
Still testing, but it all seems to work. I'd like to drop the listener this ...
13 years, 1 month ago (2009-10-15 22:31:33 UTC) #4
woodie
This is a very exciting release! You need to get the LazyContextListener working, but I ...
13 years, 1 month ago (2009-10-16 11:16:44 UTC) #5
do_not_use
The CGI stuff is not ready to be released. If we really do need to ...
13 years, 1 month ago (2009-10-16 16:36:39 UTC) #6
do_not_use
13 years, 1 month ago (2009-10-16 19:09:39 UTC) #7
http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):

http://codereview.appspot.com/129078/diff/1/3#newcode125
Line 125: def precompilation_enabled?
On 2009/10/16 16:36:39, ribrdb wrote:
> How about adding an enable_precompilation method too?

ping?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b