add support for precompilation-enabled

[woodie, 2009-10-14 02:44:10]

this seems to work

http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):

http://codereview.appspot.com/129078/diff/1/3#newcode97
Line 97: attr_accessor :application, :inbound_services, :precompilation_enabled
had trouble with the dafault value 
when I only assigned attr_writer

http://codereview.appspot.com/129078/diff/1/3#newcode106
Line 106: 'jruby.compile.lazyHandles'   => true,
as long as we do the packaging, and we get some savings...

[woodie, 2009-10-14 05:50:34]

http://codereview.appspot.com/129078/diff/1004/6
File appengine-rack/lib/appengine-rack.rb (right):

http://codereview.appspot.com/129078/diff/1004/6#newcode106
Line 106: # 'jruby.compile.lazyHandles'   => true,
I cannot imagine that the savings here
could be worth the added complexity

[woodie, 2009-10-15 08:30:19]

you sdk rakefile is remarkable

http://codereview.appspot.com/129078/diff/1006/2009
File appengine-rack/lib/appengine-rack.rb (right):

http://codereview.appspot.com/129078/diff/1006/2009#newcode106
Line 106: # 'jruby.compile.lazyHandles'   => true,
seems reasonable to leave this in there for now

[woodie, 2009-10-15 22:31:33]

Still testing, but it all seems to work.

I'd like to drop the listener this release, worth the wait!

http://codereview.appspot.com/129078/diff/2034/1031
File appengine-tools/lib/appengine-tools/web-xml.rb (right):

http://codereview.appspot.com/129078/diff/2034/1031#newcode44
Line 44: # TODO: we need a servlet that calls
LoadOnFirstRequestApplicationFactory
this is the killer feature for this release,
and will focus our users in the right direction

[woodie, 2009-10-16 11:16:44]

This is a very exciting release!

You need to get the LazyContextListener working,
but I can see Rubyists building chunks in Duby.

I'm going to also build some of my stuff as Ruby CGI.
We should also ship a RubyCGI servlet. I hope we can
have a cgi folder, the mapped path defines the filename

http://codereview.appspot.com/129078/diff/1047/2041
File appengine-rack/src/build.sh (right):

http://codereview.appspot.com/129078/diff/1047/2041#newcode4
Line 4: export CLASSPATH=$JRUBY_RACK:servlet.jar:.
I grabbed a REALLY old version of servlet.jar
I suppose this build can require that you have the sdk

I figure I can roll this into the Rakefile
once duby and bitescript gems are available

http://codereview.appspot.com/129078/diff/1047/2049
File appengine-tools/lib/appengine-tools/bundler.rb (right):

http://codereview.appspot.com/129078/diff/1047/2049#newcode82
Line 82: JRUBY_RACK_URL = "http://kenai.com/downloads/jruby-rack/#{JRUBY_RACK}"
this is the new URL, old one redirects

http://codereview.appspot.com/129078/diff/1047/2051
File appengine-tools/lib/appengine-tools/update_check.rb (right):

http://codereview.appspot.com/129078/diff/1047/2051#newcode83
Line 83: puts "=> Please run #{prefix} gem update #{name}."
normal messages should have the '=>' prefix
errors should not, not sure which this is.

http://codereview.appspot.com/129078/diff/1047/2052
File appengine-tools/lib/appengine-tools/web-xml.rb (right):

http://codereview.appspot.com/129078/diff/1047/2052#newcode44
Line 44: use JavaContextListener,
'com.google.appengine.jruby.LazyContextListener'
maybe this should ship with our Java SDK

[do_not_use, 2009-10-16 16:36:39]

The CGI stuff is not ready to be released. If we really do need to release it,
we need to spend some time making it better.

http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):

http://codereview.appspot.com/129078/diff/1/3#newcode125
Line 125: def precompilation_enabled?
How about adding an enable_precompilation method too?

http://codereview.appspot.com/129078/diff/1047/2041
File appengine-rack/src/build.sh (right):

http://codereview.appspot.com/129078/diff/1047/2041#newcode4
Line 4: export CLASSPATH=$JRUBY_RACK:servlet.jar:.
Maybe we should just include the .class files for now, because of the
dependencies? Also, I think it would be better to put this stuff in the jruby
jar than here.
On 2009/10/16 11:16:44, woodie wrote:
> I grabbed a REALLY old version of servlet.jar
> I suppose this build can require that you have the sdk
> 
> I figure I can roll this into the Rakefile
> once duby and bitescript gems are available
>

http://codereview.appspot.com/129078/diff/1047/2054
File jruby-abridged/Rakefile (right):

http://codereview.appspot.com/129078/diff/1047/2054#newcode82
Line 82: cp_r(File.join(ROOT, '..', 'appengine-rack', 'src',
If they're going into this jar, I think the source files should be in this
directory.

[do_not_use, 2009-10-16 19:09:39]

http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):

http://codereview.appspot.com/129078/diff/1/3#newcode125
Line 125: def precompilation_enabled?
On 2009/10/16 16:36:39, ribrdb wrote:
> How about adding an enable_precompilation method too?

ping?