Minor clean ups from model unification.

Minor clean ups from model unification.

* XXX notes have been consolidated to indicate what should actually be done once
possible.
* The checks in BrowserCharm.parse have been updated based on investigation into
the PyJuju and GoJuju environments. As the data passed is consistently in one
form or another, we now just check if "config" exists and parse
the data as needed in that case.

https://code.launchpad.net/~jcsackett/juju-gui/charm-unification-cleanup/+merge/180008

(do not edit description out of merge proposal)

[j.c.sackett, 2013-08-13 21:43:04]

Please take a look.

[j.c.sackett, 2013-08-14 13:52:58]

Please take a look.

[matthew.scott, 2013-08-14 16:23:10]

LGTM, thanks

[rharding, 2013-08-14 17:48:49]

LGTM though I don't get parse called on the super class? Can you verify/double
check that?

https://codereview.appspot.com/12897043/diff/4001/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/12897043/diff/4001/app/models/charm.js#newcode518
app/models/charm.js:518: var data =
models.BrowserCharm.superclass.parse.apply(this, arguments),
why is this calling it's own method?

[j.c.sackett, 2013-08-14 20:12:15]

>
https://codereview.appspot.com/12897043/diff/4001/app/models/charm.js#newcode518
> app/models/charm.js:518: var data =
> models.BrowserCharm.superclass.parse.apply(this, arguments),
> why is this calling it's own method?

It's calling the Models.parse method, I assume. This is a port from what Charm
did.

[j.c.sackett, 2013-08-14 21:57:56]

*** Submitted:

Minor clean ups from model unification.

* XXX notes have been consolidated to indicate what should actually be done once
possible.
* The checks in BrowserCharm.parse have been updated based on investigation into
the PyJuju and GoJuju environments. As the data passed is consistently in one
form or another, we now just check if "config" exists and parse
the data as needed in that case.

R=matthew.scott, rharding
CC=
https://codereview.appspot.com/12897043