Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 12892043: Add Claims support to web-app-policy-ACL (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Tanmay Vartak
Modified:
7 years, 8 months ago
Reviewers:
ejona
CC:
connector-cr_google.com
Visibility:
Public.

Description

Add Claims support to web-app-policy-ACL

Patch Set 1 #

Patch Set 2 : Integration with people.asmx to identify principal type for policy user #

Total comments: 14

Patch Set 3 : with code review comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+663 lines, -37 lines) Patch
A People.wsdl View 1 chunk +195 lines, -0 lines 0 comments Download
A People.spec.wsdl View 1 chunk +195 lines, -0 lines 0 comments Download
M build.xml View 1 2 1 chunk +14 lines, -1 line 0 comments Download
M src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java View 1 2 14 chunks +84 lines, -14 lines 2 comments Download
M test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java View 1 2 17 chunks +175 lines, -21 lines 0 comments Download

Messages

Total messages: 9
Tanmay Vartak
7 years, 9 months ago (2013-08-13 20:57:31 UTC) #1
Tanmay Vartak
On 2013/08/13 20:57:31, Tanmay Vartak wrote: There are some lint fixes with Authentication -- > ...
7 years, 9 months ago (2013-08-13 21:01:09 UTC) #2
ejona
On 2013/08/13 21:01:09, Tanmay Vartak wrote: > Also with integration of people web service, we ...
7 years, 9 months ago (2013-08-14 00:34:55 UTC) #3
Tanmay Vartak
7 years, 9 months ago (2013-08-14 19:48:21 UTC) #4
Tanmay Vartak
On 2013/08/14 19:48:21, Tanmay Vartak wrote: There are still some lint fixes with Authentication -- ...
7 years, 9 months ago (2013-08-14 19:51:28 UTC) #5
ejona
https://codereview.appspot.com/12892043/diff/5001/build.xml File build.xml (right): https://codereview.appspot.com/12892043/diff/5001/build.xml#newcode163 build.xml:163: <arg value="com.microsoft.schemas.sharepoint.soap.authentication"/> :-/ mixing of changes... https://codereview.appspot.com/12892043/diff/5001/build.xml#newcode168 build.xml:168: <exec ...
7 years, 9 months ago (2013-08-15 21:59:32 UTC) #6
Tanmay Vartak
On 2013/08/15 21:59:32, ejona wrote: > https://codereview.appspot.com/12892043/diff/5001/build.xml > File build.xml (right): > > https://codereview.appspot.com/12892043/diff/5001/build.xml#newcode163 > ...
7 years, 9 months ago (2013-08-16 23:23:42 UTC) #7
Tanmay Vartak
7 years, 8 months ago (2013-08-19 22:49:04 UTC) #8
ejona
7 years, 8 months ago (2013-08-20 00:25:38 UTC) #9
LGTM

https://codereview.appspot.com/12892043/diff/15001/src/com/google/enterprise/...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/12892043/diff/15001/src/com/google/enterprise/...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:1719: } else
if (loginName.startsWith("c:0+.w|")) {
Remove randomly added spaces.

https://codereview.appspot.com/12892043/diff/15001/src/com/google/enterprise/...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2174: 
Remove randomly added spaces.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b