Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 12869043: code review 12869043: sync/atomic: trigger paging fault early on linux/arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
rsc, bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

sync/atomic: trigger paging fault early on linux/arm so that we don't need to traceback through __kuser_cmpxchg

Patch Set 1 #

Patch Set 2 : diff -r 2a6434ea7154 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 2a6434ea7154 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 2a6434ea7154 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 2a6434ea7154 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 77ceb1db4a1e https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/pkg/sync/atomic/asm_linux_arm.s View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2013-08-13 17:10:37 UTC) #1
bradfitz
LGTM On Aug 13, 2013 10:10 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev1, > > Message: ...
10 years, 7 months ago (2013-08-13 17:11:33 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=303967bfd300 *** sync/atomic: trigger paging fault early on linux/arm so that we ...
10 years, 7 months ago (2013-08-13 17:16:14 UTC) #3
rsc
10 years, 7 months ago (2013-08-13 18:38:10 UTC) #4
FWIW I like this better than modifying the traceback routines. Let's live
with this until it becomes a problem.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b