Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(196)

Issue 12866043: Import support for deployer format

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bcsaller
Modified:
10 years, 7 months ago
Reviewers:
rharding, mp+179955, matthew.scott
Visibility:
Public.

Description

Import support for deployer format Databases can import deployer format dumps with some options around handling items as ghosts or not. https://code.launchpad.net/~bcsaller/juju-gui/import-deployer/+merge/179955 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Import support for deployer format #

Total comments: 36

Patch Set 3 : Import support for deployer format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -111 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M app/models/models.js View 1 2 5 chunks +337 lines, -1 line 0 comments Download
M app/store/charm.js View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 6 chunks +7 lines, -100 lines 0 comments Download
M app/views/inspector.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test_model.js View 1 2 1 chunk +164 lines, -7 lines 0 comments Download
M test/utils.js View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8
bcsaller
Please take a look.
10 years, 7 months ago (2013-08-13 16:27:07 UTC) #1
benjamin.saller
I found an issue with the inherits logic, its supposed to do multi, not single ...
10 years, 7 months ago (2013-08-13 21:17:38 UTC) #2
bcsaller
Please take a look.
10 years, 7 months ago (2013-08-13 23:12:25 UTC) #3
matthew.scott
LGTM with comments, most of which are trivial or docs, with the big one being ...
10 years, 7 months ago (2013-08-14 17:04:23 UTC) #4
rharding
Please give this a look over. Some trivial, some questions, and it looks like a ...
10 years, 7 months ago (2013-08-14 18:21:07 UTC) #5
rharding
LGTM though without the change to charm not returning the response but response.charm.
10 years, 7 months ago (2013-08-14 18:34:01 UTC) #6
benjamin.saller
Thanks for the reviews, fixed the promiseCharm interface issue. https://codereview.appspot.com/12866043/diff/5001/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/12866043/diff/5001/app/models/models.js#newcode519 app/models/models.js:519: ...
10 years, 7 months ago (2013-08-14 20:38:42 UTC) #7
bcsaller
10 years, 7 months ago (2013-08-14 20:46:24 UTC) #8
*** Submitted:

Import support for deployer format

Databases can import deployer format dumps with some options around
handling items as ghosts or not.

R=benjamin.saller, matthew.scott, rharding
CC=
https://codereview.appspot.com/12866043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b