Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(858)

Issue 127860043: Use aligned-on-x-parent instead of other callbacks for some grobs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by janek
Modified:
9 years, 6 months ago
Reviewers:
Keith, pkx166h, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix bugs with aligning on main part of the NoteColumn NoteColumns may contain either noteheads or rests, so the function was changed to handle the case when NoteColumn contains only rest. ly_scm2bool returns true when the argument is unset - that's not what we want: unset properties should evaluate to false. Use aligned-on-x-parent instead of other callbacks for some grobs Now that we have an easy way of specifying different alignments for grob and its parent (see 0c4f221e5d), we can use aligned-on-.-parent in places that we previously used .-aligned-on-self. With this change, the users have more control over the placement of grobs. Affected grobs: - InstrumentSwitch - Script - SostenutoPedal - SustainPedal - UnaCordaPedal

Patch Set 1 #

Total comments: 1

Patch Set 2 : don't mess with Flag #

Patch Set 3 : fix problems with TabNoteHeads and scripts attached to NoteColumns #

Total comments: 2

Patch Set 4 : add missing interface to TabNoteHead #

Patch Set 5 : Leave TabNoteHeads alone (opened issue 4073 for them) #

Total comments: 1

Patch Set 6 : initialize pointer to 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lily/note-column.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18
Keith
https://codereview.appspot.com/127860043/diff/1/lily/flag.cc File lily/flag.cc (left): https://codereview.appspot.com/127860043/diff/1/lily/flag.cc#oldcode40 lily/flag.cc:40: DECLARE_SCHEME_CALLBACK (calc_x_offset, (SCM)); The docs use this, so we ...
9 years, 7 months ago (2014-08-10 19:38:02 UTC) #1
janek
don't mess with Flag
9 years, 7 months ago (2014-08-10 21:10:57 UTC) #2
janek
fix problems with TabNoteHeads and scripts attached to NoteColumns
9 years, 7 months ago (2014-08-17 15:08:13 UTC) #3
Keith
Looks fine; just a minor unrelated change in code-organization looks unwise. https://codereview.appspot.com/127860043/diff/40001/lily/lily-guile.cc File lily/lily-guile.cc (right): ...
9 years, 7 months ago (2014-08-18 04:57:09 UTC) #4
janek
https://codereview.appspot.com/127860043/diff/40001/lily/lily-guile.cc File lily/lily-guile.cc (right): https://codereview.appspot.com/127860043/diff/40001/lily/lily-guile.cc#newcode201 lily/lily-guile.cc:201: robust_scm2bool (SCM b, bool def) On 2014/08/18 04:57:08, Keith ...
9 years, 7 months ago (2014-08-18 06:09:44 UTC) #5
janek
add missing interface to TabNoteHead
9 years, 7 months ago (2014-08-19 06:53:06 UTC) #6
dak
On 2014/08/18 06:09:44, janek wrote: > As far as i can see, the code for ...
9 years, 7 months ago (2014-08-20 08:50:55 UTC) #7
janek
Leave TabNoteHeads alone (opened issue 4073 for them)
9 years, 7 months ago (2014-08-23 13:58:36 UTC) #8
janek
2014-08-20 10:50 GMT+02:00 <dak@gnu.org>: > Somewhat irritatingly, separately to to_boolean there _does_ exist a > ...
9 years, 7 months ago (2014-08-23 14:01:57 UTC) #9
janek
Thanks for reviewing! I have pushed this as commit 48678617b169957433c562612151f2a71be50b59 Author: Janek Warchoł <lemniskata.bernoullego@gmail.com> Date: ...
9 years, 7 months ago (2014-08-27 07:45:02 UTC) #10
dak
https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc File lily/note-column.cc (right): https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc#newcode167 lily/note-column.cc:167: Grob *main_head; This is a catastrophic error. If get_stem ...
9 years, 7 months ago (2014-08-29 22:21:31 UTC) #11
pkx166h
On 2014/08/29 22:21:31, dak wrote: > https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc > File lily/note-column.cc (right): > > https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc#newcode167 > ...
9 years, 7 months ago (2014-08-30 09:35:26 UTC) #12
dak
On 2014/08/30 09:35:26, J_lowe wrote: > On 2014/08/29 22:21:31, dak wrote: > > https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc > ...
9 years, 7 months ago (2014-08-30 09:45:02 UTC) #13
janek
2014-08-30 0:21 GMT+02:00 <dak@gnu.org>: > > https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc > File lily/note-column.cc (right): > > https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc#newcode167 > ...
9 years, 7 months ago (2014-08-30 11:43:39 UTC) #14
janek
initialize pointer to 0
9 years, 6 months ago (2014-09-03 22:20:00 UTC) #15
janek
Hi David, i apologize for the delay - i'm loosing grip on my lilypond stuff ...
9 years, 6 months ago (2014-09-03 22:31:37 UTC) #16
janek
pushed as commit dc067afa0915bb0ecbd34d2f7f413f616d893c32 Author: Janek Warchoł <lemniskata.bernoullego@gmail.com> Date: Thu Sep 4 00:17:55 2014 +0200 ...
9 years, 6 months ago (2014-09-08 06:51:35 UTC) #17
janek
9 years, 6 months ago (2014-09-08 06:51:36 UTC) #18
Message was sent while issue was closed.
pushed as 

commit dc067afa0915bb0ecbd34d2f7f413f616d893c32
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Thu Sep 4 00:17:55 2014 +0200

    Initialize main_head to 0 (in Note_column::calc_main_extent)
    
    Make sure that the pointer won't be assigned a random value.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b