code review 126840043: time: Fix missing colon when formatting time zone offse...

time: Fix missing colon when formatting time zone offsets with seconds

When formatting time zone offsets with seconds using the stdISO8601Colon
and stdNumColon layouts, the colon was missing between the hour and minute
parts.

Fixes issue 8497.

[jstemmer, 2014-08-08 09:19:00]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-08-08 13:47:50]

I think you should add "Fixes issue 8497." to the CL description.  Unless it
doesn't fix it, of course.

[gobot, 2014-08-08 13:49:02]

R=r@golang.org (assigned by iant@golang.org)

[jstemmer, 2014-08-08 14:05:29]

On 2014/08/08 13:47:50, iant wrote:
> I think you should add "Fixes issue 8497." to the CL description.  Unless it
> doesn't fix it, of course.

This indeed fixes the issue, I've updated the description.

[r, 2014-08-08 17:44:26]

LGTM

[r, 2014-08-08 17:46:15]

On 2014/08/08 17:44:26, r wrote:
> LGTM

You need to sign the CLA as explained at
http://golang.org/doc/contribute.html#copyright

[jstemmer, 2014-08-08 19:38:22]

On 2014/08/08 17:46:15, r wrote:
> On 2014/08/08 17:44:26, r wrote:
> > LGTM
> 
> You need to sign the CLA as explained at
> http://golang.org/doc/contribute.html#copyright

I've signed the CLA.

[r, 2014-08-08 19:40:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=47a2fba45662 ***

time: Fix missing colon when formatting time zone offsets with seconds

When formatting time zone offsets with seconds using the stdISO8601Colon
and stdNumColon layouts, the colon was missing between the hour and minute
parts.

Fixes issue 8497.

LGTM=r
R=golang-codereviews, iant, gobot, r
CC=golang-codereviews
https://codereview.appspot.com/126840043

Committer: Rob Pike <r@golang.org>