Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(583)

Issue 126840043: code review 126840043: time: Fix missing colon when formatting time zone offse...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by jstemmer
Modified:
6 years, 5 months ago
Reviewers:
r
CC:
golang-codereviews, iant, gobot, r
Visibility:
Public.

Description

time: Fix missing colon when formatting time zone offsets with seconds When formatting time zone offsets with seconds using the stdISO8601Colon and stdNumColon layouts, the colon was missing between the hour and minute parts. Fixes issue 8497.

Patch Set 1 #

Patch Set 2 : diff -r a4de97b5ea66bcddd4299016729a29c1683b8592 https://code.google.com/p/go #

Patch Set 3 : diff -r 6700bc3c932e8e488267c02c2f325e2d0e8887db https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/pkg/time/format.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/format_test.go View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8
jstemmer
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
6 years, 5 months ago (2014-08-08 09:19:00 UTC) #1
iant
I think you should add "Fixes issue 8497." to the CL description. Unless it doesn't ...
6 years, 5 months ago (2014-08-08 13:47:50 UTC) #2
gobot
R=r@golang.org (assigned by iant@golang.org)
6 years, 5 months ago (2014-08-08 13:49:02 UTC) #3
jstemmer
On 2014/08/08 13:47:50, iant wrote: > I think you should add "Fixes issue 8497." to ...
6 years, 5 months ago (2014-08-08 14:05:29 UTC) #4
r
LGTM
6 years, 5 months ago (2014-08-08 17:44:26 UTC) #5
r
On 2014/08/08 17:44:26, r wrote: > LGTM You need to sign the CLA as explained ...
6 years, 5 months ago (2014-08-08 17:46:15 UTC) #6
jstemmer
On 2014/08/08 17:46:15, r wrote: > On 2014/08/08 17:44:26, r wrote: > > LGTM > ...
6 years, 5 months ago (2014-08-08 19:38:22 UTC) #7
r
6 years, 5 months ago (2014-08-08 19:40:36 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=47a2fba45662 ***

time: Fix missing colon when formatting time zone offsets with seconds

When formatting time zone offsets with seconds using the stdISO8601Colon
and stdNumColon layouts, the colon was missing between the hour and minute
parts.

Fixes issue 8497.

LGTM=r
R=golang-codereviews, iant, gobot, r
CC=golang-codereviews
https://codereview.appspot.com/126840043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b