code review 126790043: cmd/{ld,link,objdump}, runtime, debug/gosym: move linke...

cmd/{ld,link,objdump}, runtime, debug/gosym: move linker-defined symbols into runtime package

Fixes issue 8092.

[rsc, 2014-08-28 00:06:29]

LGTM

[mdempsky, 2014-08-28 00:07:45]

Hello iant@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com,
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2014-08-28 00:09:56]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[rsc, 2014-08-28 00:15:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=8b5fc7c59d05 ***

cmd/{ld,link,objdump}, runtime, debug/gosym: move linker-defined symbols into
runtime package

Fixes issue 8092.

LGTM=rsc
R=iant, rsc
CC=golang-codereviews
https://codereview.appspot.com/126790043

Committer: Russ Cox <rsc@golang.org>

[gobot, 2014-08-28 00:23:36]

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/0339a8530a8b10d9bbab4db9984734804ac80979

[mdempsky, 2014-08-28 00:25:46]

On Wed, Aug 27, 2014 at 5:23 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the windows-amd64 builder.
> See http://build.golang.org/log/0339a8530a8b10d9bbab4db9984734804ac80979


Looks legit.  I'll investigate.

--- FAIL: TestAddr2Line (0.84s)
	addr2line_test.go:45: go tool addr2line
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\addr2line\_test\addr2line.test.exe:
exit status 1
		addr2line: reading
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\addr2line\_test\addr2line.test.exe:
no pclntab symbol found
FAIL
FAIL	cmd/addr2line	0.865s

--- FAIL: TestObjDump (1.78s)
	objdump_test.go:56: go tool objdump
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\objdump\_test\objdump.test.exe:
exit status 1
		objdump: reading
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\objdump\_test\objdump.test.exe:
no pclntab symbol found
--- FAIL: TestDisasm (1.92s)
	objdump_test.go:182: objdump fmthello.exe: exit status 1
		objdump: reading
C:\Users\ADMINI~1\AppData\Local\Temp\2\TestObjDump228294670\hello.exe:
no pclntab symbol found
FAIL
FAIL	cmd/objdump	3.735s

[iant, 2014-08-28 00:30:08]

On Wed, Aug 27, 2014 at 5:25 PM, Matthew Dempsky <mdempsky@google.com> wrote:
> On Wed, Aug 27, 2014 at 5:23 PM, <gobot@golang.org> wrote:
>>
>> This CL appears to have broken the windows-amd64 builder.
>> See http://build.golang.org/log/0339a8530a8b10d9bbab4db9984734804ac80979
>
>
> Looks legit.  I'll investigate.
>
> --- FAIL: TestAddr2Line (0.84s)
> 	addr2line_test.go:45: go tool addr2line
>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\addr2line\_test\addr2line.test.exe:
> exit status 1
> 		addr2line: reading
>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\addr2line\_test\addr2line.test.exe:
> no pclntab symbol found
> FAIL
> FAIL	cmd/addr2line	0.865s
>
> --- FAIL: TestObjDump (1.78s)
> 	objdump_test.go:56: go tool objdump
>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\objdump\_test\objdump.test.exe:
> exit status 1
> 		objdump: reading
>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\objdump\_test\objdump.test.exe:
> no pclntab symbol found
> --- FAIL: TestDisasm (1.92s)
> 	objdump_test.go:182: objdump fmthello.exe: exit status 1
> 		objdump: reading
> C:\Users\ADMINI~1\AppData\Local\Temp\2\TestObjDump228294670\hello.exe: no
> pclntab symbol found
> FAIL
> FAIL	cmd/objdump	3.735s



As you've probably already seen, objdump/main.go and addr2line/main.go
look for the symbols pclntab, epclntab, symtab, and esymtab by name on
Windows.  That will have to change.

Ian

[iant, 2014-08-28 00:30:34]

On Wed, Aug 27, 2014 at 5:30 PM, Ian Lance Taylor <iant@golang.org> wrote:
> On Wed, Aug 27, 2014 at 5:25 PM, Matthew Dempsky <mdempsky@google.com> wrote:
>> On Wed, Aug 27, 2014 at 5:23 PM, <gobot@golang.org> wrote:
>>>
>>> This CL appears to have broken the windows-amd64 builder.
>>> See http://build.golang.org/log/0339a8530a8b10d9bbab4db9984734804ac80979
>>
>>
>> Looks legit.  I'll investigate.
>>
>> --- FAIL: TestAddr2Line (0.84s)
>>       addr2line_test.go:45: go tool addr2line
>>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\addr2line\_test\addr2line.test.exe:
>> exit status 1
>>               addr2line: reading
>>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\addr2line\_test\addr2line.test.exe:
>> no pclntab symbol found
>> FAIL
>> FAIL  cmd/addr2line   0.865s
>>
>> --- FAIL: TestObjDump (1.78s)
>>       objdump_test.go:56: go tool objdump
>>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\objdump\_test\objdump.test.exe:
>> exit status 1
>>               objdump: reading
>>
C:\Users\ADMINI~1\AppData\Local\Temp\2\go-build565855203\cmd\objdump\_test\objdump.test.exe:
>> no pclntab symbol found
>> --- FAIL: TestDisasm (1.92s)
>>       objdump_test.go:182: objdump fmthello.exe: exit status 1
>>               objdump: reading
>> C:\Users\ADMINI~1\AppData\Local\Temp\2\TestObjDump228294670\hello.exe: no
>> pclntab symbol found
>> FAIL
>> FAIL  cmd/objdump     3.735s
>
>
>
> As you've probably already seen, objdump/main.go and addr2line/main.go
> look for the symbols pclntab, epclntab, symtab, and esymtab by name on
> Windows.  That will have to change.

Sorry, just objdump/main.go, not addr2line.

Ian

[brainman, 2014-08-28 00:35:51]

On 2014/08/28 00:25:46, mdempsky wrote:
> On Wed, Aug 27, 2014 at 5:23 PM, <mailto:gobot@golang.org> wrote:
> 
> > This CL appears to have broken the windows-amd64 builder.
> > See http://build.golang.org/log/0339a8530a8b10d9bbab4db9984734804ac80979
> 
> 
> Looks legit.  I'll investigate.
> 

I am looking at it too. Let me know how you go, if you find anything.

Alex

[mdempsky, 2014-08-28 00:38:49]

On Wed, Aug 27, 2014 at 5:35 PM, <alex.brainman@gmail.com> wrote:

> I am looking at it too. Let me know how you go, if you find anything.
>

I believe https://codereview.appspot.com/138770043/ should fix this.  I've
quickly tested by cross-compiling to windows/amd64 from linux/amd64, and it
seems to work.