Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(479)

Issue 125120043: code review 125120043: cmd/cgo: fix default alignment for empty structs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by mdempsky
Modified:
5 years, 2 months ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

cmd/cgo: fix default alignment for empty structs Fixes issue 5242.

Patch Set 1 #

Patch Set 2 : diff -r d37e1b0c2c65 https://code.google.com/p/go #

Patch Set 3 : diff -r d37e1b0c2c65 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M misc/cgo/test/cgo_test.go View 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue5242.go View 1 chunk +31 lines, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mdempsky
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 2 months ago (2014-08-12 05:01:15 UTC) #1
iant
LGTM
5 years, 2 months ago (2014-08-12 05:05:50 UTC) #2
iant
5 years, 2 months ago (2014-08-12 05:10:21 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=58026885ac66 ***

cmd/cgo: fix default alignment for empty structs

Fixes issue 5242.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/125120043

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b