code review 124770044: goauth2/compute/serviceaccount: fix required header for...

goauth2/compute/serviceaccount: fix required header for metadata v1

https://developers.google.com/compute/docs/metadata#transitioning
says v1 requires "Metadata-Flavor: Google" instead of
"X-Google-Metadata-Request: True".

[bradfitz, 2014-08-06 15:44:21]

LGTM



On Tue, Aug 5, 2014 at 11:54 PM, ukai via golang-codereviews <
golang-codereviews@googlegroups.com> wrote:

> Reviewers: golang-codereviews,
>
> Description:
> goauth2/compute/serviceaccount: fix required header for metadata v1
>
> https://developers.google.com/compute/docs/metadata#transitioning
> says v1 requires "Metadata-Flavor: Google" instead of
> "X-Google-Metadata-Request: True".
>
> Please review this at https://codereview.appspot.com/124770044/
>
> Affected files (+3, -3 lines):
>   M compute/serviceaccount/serviceaccount.go
>
>
> Index: compute/serviceaccount/serviceaccount.go
> ===================================================================
> --- a/compute/serviceaccount/serviceaccount.go
> +++ b/compute/serviceaccount/serviceaccount.go
> @@ -90,8 +90,8 @@
>  // Refresh renews the transport's AccessToken.
>  // t.mu sould be held when this is called.
>  func (t *transport) refresh() error {
> -       // https://developers.google.com/compute/docs/metadata
> -       // v1 requires "X-Google-Metadata-Request: True" header.
> +       // https://developers.google.com/compute/docs/metadata#
> transitioning
> +       // v1 requires "Metadata-Flavor: Google" header.
>         tokenURL := &url.URL{
>                 Scheme: "http",
>                 Host:   metadataServer,
> @@ -101,7 +101,7 @@
>         if err != nil {
>                 return err
>         }
> -       req.Header.Add("X-Google-Metadata-Request", "True")
> +       req.Header.Add("Metadata-Flavor", "Google")
>         resp, err := http.DefaultClient.Do(req)
>         if err != nil {
>                 return err
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[bradfitz, 2014-08-06 15:46:37]

My hgrc is messed up so I just gave you commit access instead. hg submit
away.



On Wed, Aug 6, 2014 at 8:44 AM, Brad Fitzpatrick <bradfitz@golang.org>
wrote:

> LGTM
>
>
>
> On Tue, Aug 5, 2014 at 11:54 PM, ukai via golang-codereviews <
> golang-codereviews@googlegroups.com> wrote:
>
>> Reviewers: golang-codereviews,
>>
>> Description:
>> goauth2/compute/serviceaccount: fix required header for metadata v1
>>
>> https://developers.google.com/compute/docs/metadata#transitioning
>> says v1 requires "Metadata-Flavor: Google" instead of
>> "X-Google-Metadata-Request: True".
>>
>> Please review this at https://codereview.appspot.com/124770044/
>>
>> Affected files (+3, -3 lines):
>>   M compute/serviceaccount/serviceaccount.go
>>
>>
>> Index: compute/serviceaccount/serviceaccount.go
>> ===================================================================
>> --- a/compute/serviceaccount/serviceaccount.go
>> +++ b/compute/serviceaccount/serviceaccount.go
>> @@ -90,8 +90,8 @@
>>  // Refresh renews the transport's AccessToken.
>>  // t.mu sould be held when this is called.
>>  func (t *transport) refresh() error {
>> -       // https://developers.google.com/compute/docs/metadata
>> -       // v1 requires "X-Google-Metadata-Request: True" header.
>> +       // https://developers.google.com/compute/docs/metadata#
>> transitioning
>> +       // v1 requires "Metadata-Flavor: Google" header.
>>         tokenURL := &url.URL{
>>                 Scheme: "http",
>>                 Host:   metadataServer,
>> @@ -101,7 +101,7 @@
>>         if err != nil {
>>                 return err
>>         }
>> -       req.Header.Add("X-Google-Metadata-Request", "True")
>> +       req.Header.Add("Metadata-Flavor", "Google")
>>         resp, err := http.DefaultClient.Do(req)
>>         if err != nil {
>>                 return err
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

[ukai, 2014-08-07 01:31:03]

Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/goauth2

[ukai, 2014-08-07 01:39:00]

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=8273d5a0e11a
***

goauth2/compute/serviceaccount: fix required header for metadata v1

https://developers.google.com/compute/docs/metadata#transitioning
says v1 requires "Metadata-Flavor: Google" instead of
"X-Google-Metadata-Request: True".

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/124770044

[ukai, 2014-08-07 01:42:40]

thanks for review and granting commit access.
sorry for lots of patch sets. I had just failed to setup password for hg repo...