LEFT | RIGHT |
(no file at all) | |
1 Getting started | 1 Getting started |
2 =============== | 2 =============== |
3 | 3 |
4 Before contributing to `juju-core` please read the following sections describing | 4 Before contributing to `juju-core` please read the following sections describing |
5 the tools and conventions of this project. This file is a companion to README | 5 the tools and conventions of this project. This file is a companion to README |
6 and it is assumed that file has been read prior. | 6 and it is assumed that file has been read prior. |
7 | 7 |
8 cobzr | 8 cobzr |
9 ----- | 9 ----- |
10 | 10 |
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
187 this is not what you want, so you should visit the bug's page and correct the | 187 this is not what you want, so you should visit the bug's page and correct the |
188 milestone, if set. | 188 milestone, if set. |
189 | 189 |
190 Code review | 190 Code review |
191 =========== | 191 =========== |
192 | 192 |
193 `juju-core` operates on a two positive, no negative review process. You may not | 193 `juju-core` operates on a two positive, no negative review process. You may not |
194 submit your proposal until it has received two LGTM comments. If any NOT LGTM | 194 submit your proposal until it has received two LGTM comments. If any NOT LGTM |
195 comments are received, those comments should be resolved to the satisfaction | 195 comments are received, those comments should be resolved to the satisfaction |
196 of the objecting reviewer before submitting. Once your have received at least | 196 of the objecting reviewer before submitting. Once your have received at least |
197 two positive reviews, you can submit your branch with `lbox` | 197 two positive reviews, you can submit your branch by going to the launchpad |
198 | 198 merge proposal page and: |
199 lbox submit | 199 |
| 200 - copy and paste the merge proposal description into the |
| 201 commit message. |
| 202 - mark the proposal as Approved. |
| 203 |
| 204 The merge proposal will then be tested and merged into trunk assuming |
| 205 all tests pass cleanly. |
200 | 206 |
201 lbox hooks | 207 lbox hooks |
202 ---------- | 208 ---------- |
203 | 209 |
204 Before proposing, `lbox` runs a number of hooks to improve code quality and | 210 Before proposing, `lbox` runs a number of hooks to improve code quality and |
205 ensure that code is properly formatted. These checks are in | 211 ensure that code is properly formatted. These checks are in |
206 `$GOPATH/src/launchpad.net/juju-core/.lbox.check`. They are run automatically | 212 `$GOPATH/src/launchpad.net/juju-core/.lbox.check`. They are run automatically |
207 by `lbox` before proposing or submitting. If these hooks fail you will have | 213 by `lbox` before proposing or submitting. If these hooks fail you will have |
208 to resolve those errors before trying again. For example | 214 to resolve those errors before trying again. For example |
209 | 215 |
210 % lbox propose | 216 % lbox propose |
211 gofmt is sad: | 217 gofmt is sad: |
212 | 218 |
213 version/version.go | 219 version/version.go |
214 | 220 |
| 221 Dependency management |
| 222 ===================== |
| 223 |
| 224 In the top-level directory, there is a file, dependencies.tsv, that |
| 225 holds the revision ids of all the external projects that juju-core |
| 226 depends on. The tab-separated columns in the file are |
| 227 the project name, the type version control system used by |
| 228 that project, and the revision id and number respectively. |
| 229 |
| 230 This file is generated by running the godeps command (which you |
| 231 can get with `go get launchpad.net/godeps') on a juju-core |
| 232 installation with all freshly downloaded directories. |
| 233 |
| 234 The bash commands used to generate it from scratch are as follows: |
| 235 |
| 236 % export GOPATH=/tmp/juju-build |
| 237 % go get launchpad.net/juju-core/... |
| 238 % go test launchpad.net/juju-core/... |
| 239 % godeps -t $(go list launchpad.net/juju-core/...) > dependencies.tsv |
LEFT | RIGHT |