Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5483)

Issue 12361043: add dependencies file

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by rog
Modified:
8 years, 9 months ago
Reviewers:
dimitern, mp+178351, gz
Visibility:
Public.

Description

add dependencies file This was produced by doing the following: % GOPATH=/tmp/go % go get launchpad.net/juju-core/... % cd /tmp/go/src/launchpad.net/juju-core % godeps -t `{go list ./...} I verified that all tests passed. https://code.launchpad.net/~rogpeppe/juju-core/358-add-godeps/+merge/178351 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : add dependencies file #

Patch Set 3 : add dependencies file #

Patch Set 4 : add dependencies file #

Patch Set 5 : add dependencies file #

Patch Set 6 : add dependencies file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M CONTRIBUTING View 1 2 3 4 5 2 chunks +28 lines, -3 lines 0 comments Download
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A dependencies.tsv View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
8 years, 9 months ago (2013-08-02 18:08:02 UTC) #1
dimitern
LGTM, nice! I'd suggest to add a script with the commands mentioned in the description, ...
8 years, 9 months ago (2013-08-05 10:29:23 UTC) #2
gz
LGTM. I prefer having godeps as a seperate project rather than a bundled script, however ...
8 years, 9 months ago (2013-08-05 12:02:56 UTC) #3
gz
8 years, 9 months ago (2013-08-07 11:47:11 UTC) #4
The additions to CONTRIBUTING (and drive by review fix) look good to me. What
we're still missing there is the process for updating a dependency such as gwacl
and landing code that needs that. However, as we've not actually done that yet,
or hammered out exactly how it will work, that's something best left for a later
branch I think.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b