Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2003)

Unified Diff: src/cmd/cgo/out.go

Issue 12350044: code review 12350044: build: on OS X use clang instead of gcc (Closed)
Patch Set: diff -r ef69e6cf3bd0 https://code.google.com/p/go/ Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cmd/cgo/gcc.go ('k') | src/cmd/dist/a.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cmd/cgo/out.go
===================================================================
--- a/src/cmd/cgo/out.go
+++ b/src/cmd/cgo/out.go
@@ -498,7 +498,7 @@
// Use __gcc_struct__ to work around http://gcc.gnu.org/PR52991 on x86,
// and http://golang.org/issue/5603.
extraAttr := ""
- if !strings.Contains(p.gccName(), "clang") && (goarch == "amd64" || goarch == "386") {
+ if !strings.Contains(p.gccBaseCmd()[0], "clang") && (goarch == "amd64" || goarch == "386") {
extraAttr = ", __gcc_struct__"
}
fmt.Fprintf(fgcc, "\t%s __attribute__((__packed__%v)) *a = v;\n", ctype, extraAttr)
« no previous file with comments | « src/cmd/cgo/gcc.go ('k') | src/cmd/dist/a.h » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b