Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2249)

Issue 1228043: #422 - bug in setting __module__

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Haoyu Bai
Modified:
3 years, 7 months ago
Reviewers:
robertwb, craigcitro
CC:
craigcitro
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 18

Patch Set 2 : fixes according to Craig's comment #

Patch Set 3 : code refactoring and add TODO mark #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -24 lines) Patch
M Cython/Compiler/ExprNodes.py View 1 2 9 chunks +28 lines, -22 lines 1 comment Download
M Cython/Compiler/Symtab.py View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
A tests/run/method_module_name_T422.pyx View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4
craigcitro
http://codereview.appspot.com/1228043/diff/1/2 File Cython/Compiler/ExprNodes.py (right): http://codereview.appspot.com/1228043/diff/1/2#newcode4210 Cython/Compiler/ExprNodes.py:4210: self.module_name = env.global_scope().module_name I'm a little confused here -- ...
3 years, 9 months ago #1
Haoyu Bai
http://codereview.appspot.com/1228043/diff/1/2 File Cython/Compiler/ExprNodes.py (right): http://codereview.appspot.com/1228043/diff/1/2#newcode4210 Cython/Compiler/ExprNodes.py:4210: self.module_name = env.global_scope().module_name On 2010/07/06 07:49:55, craigcitro wrote: > ...
3 years, 9 months ago #2
craigcitro
LGTM http://codereview.appspot.com/1228043/diff/1/2 File Cython/Compiler/ExprNodes.py (right): http://codereview.appspot.com/1228043/diff/1/2#newcode4210 Cython/Compiler/ExprNodes.py:4210: self.module_name = env.global_scope().module_name > I'll switch to qualified_name ...
3 years, 8 months ago #3
Haoyu Bai
3 years, 7 months ago #4
http://codereview.appspot.com/1228043/diff/12001/Cython/Compiler/ExprNodes.py
File Cython/Compiler/ExprNodes.py (left):

http://codereview.appspot.com/1228043/diff/12001/Cython/Compiler/ExprNodes.py...
Cython/Compiler/ExprNodes.py:4404: 
This is the solution I came up for unify the duplicated code... Well actually I
don't like the indirecting level it adds on. But I can't get any better
solution.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5