Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1767)

Issue 122150043: cmd/cgo: consistently map void* to *byte under -{c,go}defs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by mdempsky
Modified:
5 years, 2 months ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

cmd/cgo: consistently map void* to *byte under -{c,go}defs Fixes issue 8478.

Patch Set 1 #

Patch Set 2 : diff -r 0015a2541545 https://code.google.com/p/go #

Total comments: 4

Patch Set 3 : diff -r 0015a2541545 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
A misc/cgo/testgodefs/issue8478.go View 1 chunk +20 lines, -0 lines 0 comments Download
M misc/cgo/testgodefs/main.go View 1 chunk +3 lines, -0 lines 0 comments Download
M misc/cgo/testgodefs/test.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/cgo/gcc.go View 8 chunks +12 lines, -30 lines 0 comments Download

Messages

Total messages: 6
mdempsky
PTAL
5 years, 2 months ago (2014-08-06 04:20:31 UTC) #1
iant
https://codereview.appspot.com/122150043/diff/20001/misc/cgo/testgodefs/issue8478.go File misc/cgo/testgodefs/issue8478.go (right): https://codereview.appspot.com/122150043/diff/20001/misc/cgo/testgodefs/issue8478.go#newcode20 misc/cgo/testgodefs/issue8478.go:20: type Issue8478_S C.s Go names don't normally include underscores, ...
5 years, 2 months ago (2014-08-06 13:46:15 UTC) #2
mdempsky
https://codereview.appspot.com/122150043/diff/20001/misc/cgo/testgodefs/main.go File misc/cgo/testgodefs/main.go (right): https://codereview.appspot.com/122150043/diff/20001/misc/cgo/testgodefs/main.go#newcode12 misc/cgo/testgodefs/main.go:12: func issue8478(s *Issue8478_S) { On 2014/08/06 13:46:15, iant wrote: ...
5 years, 2 months ago (2014-08-06 15:22:22 UTC) #3
mdempsky
https://codereview.appspot.com/122150043/diff/20001/misc/cgo/testgodefs/issue8478.go File misc/cgo/testgodefs/issue8478.go (right): https://codereview.appspot.com/122150043/diff/20001/misc/cgo/testgodefs/issue8478.go#newcode20 misc/cgo/testgodefs/issue8478.go:20: type Issue8478_S C.s On 2014/08/06 13:46:15, iant wrote: > ...
5 years, 2 months ago (2014-08-06 17:10:21 UTC) #4
iant
LGTM Thanks.
5 years, 2 months ago (2014-08-06 17:23:39 UTC) #5
iant
5 years, 2 months ago (2014-08-06 17:28:23 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=dad4822bccff ***

cmd/cgo: consistently map void* to *byte under -{c,go}defs

Fixes issue 8478.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/122150043

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b