Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 121880043: code review 121880043: undo CL 107280044 / ee11f19bc514 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by mikio
Modified:
8 years ago
Reviewers:
r, gobot
CC:
r, golang-codereviews
Visibility:
Public.

Description

undo CL 107280044 / ee11f19bc514 preparing for the syscall package freeze. ««« original CL description syscall: consolidate, simplify socket options for Unix-like systems Also exposes common socket option functions on Solaris. Update issue 7174 Update issue 7175 LGTM=aram R=golang-codereviews, aram CC=golang-codereviews https://codereview.appspot.com/107280044 »»»

Patch Set 1 #

Patch Set 2 : diff -r aa436887421e https://code.google.com/p/go #

Patch Set 3 : diff -r 7efac551d52c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -58 lines) Patch
M src/pkg/syscall/syscall_bsd.go View 1 chunk +42 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 2 chunks +34 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_unix.go View 3 chunks +16 lines, -58 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years ago (2014-07-30 00:50:59 UTC) #1
r
LGTM
8 years ago (2014-07-30 00:53:38 UTC) #2
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=c860a8702b1b *** undo CL 107280044 / ee11f19bc514 preparing for the syscall package ...
8 years ago (2014-07-30 01:02:25 UTC) #3
gobot
8 years ago (2014-07-30 01:21:17 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/56ae33a74fe97b47199647890110ea7c2ee84419
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b