Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5787)

Issue 12115043: Removes charm store from fakebackend

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by j.c.sackett
Modified:
10 years, 9 months ago
Reviewers:
mp+177636, jeff.pihach, matthew.scott
Visibility:
Public.

Description

Removes charm store from fakebackend -Rewrote the backend to use the API store to query for the charm. -Updated model to provide the storeId in charmParts instead of the no longer needed charm_store_path -Updated model to set requires/provides from the API relations data. -Added api-response json files for tests -Provided new cached_charms in tests using new API data, and created new FakeBackend (without charmstore) -Updated tests, including using actual charm IDs; the old ones only worked because the test processing ignored id validation. -Drive bys. https://code.launchpad.net/~jcsackett/juju-gui/remove-old-api-fakebackend/+merge/177636 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removes charm store from fakebackend #

Patch Set 3 : Removes charm store from fakebackend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2072 lines, -242 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +1 line, -1 line 0 comments Download
M app/models/charm.js View 2 chunks +25 lines, -12 lines 0 comments Download
M app/store/env/fakebackend.js View 4 chunks +47 lines, -62 lines 0 comments Download
A test/data/hadoop-api-response.json View 1 chunk +283 lines, -0 lines 0 comments Download
A test/data/haproxy-api-response.json View 1 chunk +292 lines, -0 lines 0 comments Download
A test/data/mediawiki-api-response.json View 1 chunk +212 lines, -0 lines 0 comments Download
A test/data/memcached-api-response.json View 1 chunk +252 lines, -0 lines 0 comments Download
A test/data/mysql-api-response.json View 1 chunk +308 lines, -0 lines 0 comments Download
A test/data/puppet-api-response.json View 1 chunk +183 lines, -0 lines 0 comments Download
A test/data/wordpress-api-response.json View 1 chunk +219 lines, -0 lines 0 comments Download
M test/test_fakebackend.js View 1 41 chunks +95 lines, -84 lines 0 comments Download
M test/test_sandbox_go.js View 1 20 chunks +55 lines, -40 lines 0 comments Download
M test/test_sandbox_python.js View 1 25 chunks +66 lines, -38 lines 0 comments Download
M test/test_simulator.js View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.js View 2 chunks +31 lines, -4 lines 0 comments Download

Messages

Total messages: 5
j.c.sackett
Please take a look.
10 years, 9 months ago (2013-07-30 16:03:14 UTC) #1
jeff.pihach
LGTM - one step closer :) QA OK https://codereview.appspot.com/12115043/diff/1/test/test_fakebackend.js File test/test_fakebackend.js (right): https://codereview.appspot.com/12115043/diff/1/test/test_fakebackend.js#newcode114 test/test_fakebackend.js:114: 'Null ...
10 years, 9 months ago (2013-07-30 16:39:05 UTC) #2
j.c.sackett
On 2013/07/30 16:39:05, jeff.pihach wrote: > https://codereview.appspot.com/12115043/diff/1/test/utils.js#newcode171 > test/utils.js:171: makeFakeBackend: function() { > It looks ...
10 years, 9 months ago (2013-07-30 16:44:54 UTC) #3
matthew.scott
LGTM, thanks!
10 years, 9 months ago (2013-07-30 17:26:19 UTC) #4
j.c.sackett
10 years, 9 months ago (2013-07-30 22:03:37 UTC) #5
*** Submitted:

Removes charm store from fakebackend

-Rewrote the backend to use the API store to query for the charm.
-Updated model to provide the storeId in charmParts instead of the no longer
needed charm_store_path
-Updated model to set requires/provides from the API relations data.
-Added api-response json files for tests
-Provided new cached_charms in tests using new API data, and created new
FakeBackend (without charmstore)
-Updated tests, including using actual charm IDs; the old ones only worked
because the test processing ignored id validation.
-Drive bys.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/12115043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b