Issue 12037043: code review 12037043: net: fix memory leak on unix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12037043: code review 12037043: net: fix memory leak on unix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dvyukov

Modified:
10 years, 8 months ago

Reviewers:
brainman, dave

CC:
golang-dev, dave_cheney.net, brainman

Visibility:
Public.

Description

net: fix memory leak on unix If netFD is closed by finalizer, runtime netpoll descriptor is not freed.

Patch Set 1 #

Patch Set 2 : diff -r d41598ff11f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d41598ff11f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 3fd9ca3ab815 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	src/pkg/net/fd_unix.go	View	1	4 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 9 months ago (2013-07-29 16:07:31 UTC) #1

dave_cheney.net

LGTM. I'm delighted to see fd.sysfile going away. Please wait for a second reviewer.

10 years, 9 months ago (2013-07-30 04:40:19 UTC) #2

dvyukov

10 years, 8 months ago (2013-07-30 15:47:46 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=f04c9f103e15 ***

net: fix memory leak on unix
If netFD is closed by finalizer, runtime netpoll descriptor is not freed.

R=golang-dev, dave, alex.brainman
CC=golang-dev
https://codereview.appspot.com/12037043

Expand All Messages | Collapse All Messages