Issue 120200043: Remove warning when there are no noteheads to attach lyrics to.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 120200043: Remove warning when there are no noteheads to attach lyrics to. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by janek

Modified:
9 years, 9 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove warning when there are no noteheads to attach lyrics to. The warning was added to address issue 248, but it is now moot after issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less context (like Devnull) is perfectly legal now.

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	lily/lyric-engraver.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

janek

9 years, 9 months ago (2014-07-27 10:24:29 UTC) #1

Message was sent while issue was closed.

Pushed as

commit 476687b992c1c0d551b0d425e5ece78c39cfc3ef
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Sat Jul 26 09:00:39 2014 +0200

    Remove warning when there are no noteheads to attach lyrics to.
    
    The warning was added to address issue 248, but it is now moot after
    issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less context
    (like Devnull) is perfectly legal now.

Expand All Messages | Collapse All Messages